Add support for multiple order types

Hey @gonozalves,

The error is a generic exception whenever you try to use a wrapper to read from an undefined property. In this case, the issue was with commerce discount. It's trying to access $order->commerce_discounts->value() which may not exist on all order bundles. I'm not familiar with marketplace, but your error could be completely unrelated. You can try to backtrace the error on line 335 of the entity.wrapper.inc class to see what property the code is trying to access.

After looking through commerce marketplace and commerce discounts, I think there are still places to be fixed in commerce discounts as you've suggested. We need to make sure that anywhere *wrapper*->commerce_discounts is read/written to, that we check the existence of the field first. I'm setting this to needs work so that we can go through the module and update every instance with one patch.

Here's an updated patch that checks the wrapper properties existence before attempting to read/write to it in all instances.

Make sure you've reverted the change from the previous patch. The easiest way would be to grab a fresh copy of the dev release and apply it to that. I just tested locally and it worked fine.

Hey @guguss,

What modules are you using that define a new order bundle (marketplace)? Also, are you able to backtrace the calls on line 335 of entity.wrapper.inc? If you don’t have debug setup, you can put dpm(debug_backtrace()) on line 334 (with devel module enabled). From there, you should be able to see which line from commerce_discoutns is attempting to access the commerce discounts property. There’s a possibility that it’s another module that integrates with commerce_discount, or I may have missed a call in my patch. I’m on #drupal-commerce IRC if you want to chat on this.

@guguss,

I missed you on IRC it looks like. However, your screenshot shows me that the issue is in commerce coupon. "Unknown data property commerce_coupons" and not commerce_discounts (as related to this issue). I'm creating an issue there and will supply a patch as well.

@guguss, checkout #2301043: Empty check on $order->commerce_coupons to prevent fatal error for your issue with the coupon module. Feedback on that would be great as well!

I would vote for a setting where you can select the order bundles that have discounts. In which case the patch can be reverted and we can replace field checks with settings checks if that makes more sense.

@gonzalves. You already have the commit applied to your instance. The good news is that if you grab a -dev version of this module it's now included so you don't have to re-apply the patch when you update the module. For now you can just keep your module the way it is.