Use a more nuanced approach for duplicate extension detection [#2284709]

Credit to Andrew_Mallis for this one. In a perfect world, Installation Profiles would be up-to-date. But they aren't.

If equal to or less than something in an installation profile, fail.
If correctly overriding something in an installation profile, pass.

Comments

Comment #1

kreynen CreditAttribution: kreynen commented 28 August 2014 at 15:16

Worth watching...

https://github.com/drush-ops/drush/issues/280
https://github.com/drush-ops/drush/pull/430

I don't think you can really rely on = or < from versions to indicate a pass vs. fail. There are valid reasons for overridding the version of a module in a distribution with an older version of a module. Security releases are just one case that distributions struggle with. Drupal.org will now flag distributions with known security issues on their project page encouraging distribution maintainers to apply security updates in a timely manner. In a perfect world, module maintainers would only include changes related to a security update in that release. In the real world, security releases often end up including additional changes. We addressed this in the Whitelist in #1854474: drupalcode.org wildcard? only to find that drupalorg_drush prevented applying patches generated from http://cgit.drupalcode.org.

In https://www.drupal.org/project/profile_status_check we only assume that the versions are the same if they are the same version with no patches in the directory of either version. Even then, making assumptions about which version is right vs. wrong is problematic.

While giving more visual feedback when an override exists has helped several users of our distributions realize that the distribution had caught up to the version of a module they added to sites/all/modules, we're working on giving users the option to adding notes about why they originally added the override.

Trying to programmatically determine right and wrong will only lead to more false positives.

Comment #2

27 July 2015 at 19:19

FluxSauce committed 3bde326 on 7.x-1.x

Issue #2284709 by Andrew_Mallis - improving duplicate extension check by...

Comment #3

FluxSauce CreditAttribution: FluxSauce at Four Kitchens commented 27 July 2015 at 19:24

I've cleaned up the Drupal 7 version of the check to take into account overriding installation profiles.

> Trying to programmatically determine right and wrong will only lead to more false positives.

I hear what you're saying, but my goal is to provide a solution that works appropriately in the vast majority of circumstances (one size fits most). Reducing false positives is the goal of this particular request and this commit takes care of the most common one.