Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
A standalone part of #2278541: Refactor block visibility to use condition plugins is adding schema support and optional-ity to condition plugins.
Proposed resolution
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff.txt | 2.3 KB | tim.plunkett |
#3 | condition-2283929-3.patch | 13.33 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettComment #2
blueminds CreditAttribution: blueminds commentedFound only minor things:
Shouldn't these use isNegated()?
ContainerIterface seems not to be imported. Does this work because this special case does not occur during tests? Probably not that relevant as it will be removed with dependency serialization.
Comment #3
tim.plunkettGood feedback, thanks!
Comment #4
BerdirThis looks good I think. Had to check why the type validation is removed, but it's a checkboxes element, form API already ensures that you can't submit anything that's not part of the selection. Also wtf at Language as Lang....
Comment #5
webchickCommitted and pushed to 8.x. Thanks!
Comment #7
tim.plunkettThanks!