Problem/Motivation

The Aggregator module teaser_length setting is not used anywhere in 8.x.

In D7, the setting only changes the item description length in Aggregator's RSS view and then only if you have the system RSS Publishing feed content setting set to Titles plus teaser. Users thinking that the teaser length setting would change how items are displayed in Aggregator's page views have led to at least one bug report and some comments in the Related issues.

Since Aggregator's RSS feed is now generated by Views in 8.x, the teaser_length setting has no effect. At least I haven't been able to find anywhere that it's being used.

Proposed resolution

Remove the teaser_length setting from 8.x or enable it to do something, for instance by turning it into one of Aggregator's RSS View display options.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#24 2283877-24.patch8.13 KBdcam
#21 2283877-21.patch8.16 KBdcam
#17 2283877-17.patch8.08 KBdcam
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dcam’s picture

dcam CreditAttribution: dcam commented
Issue summary: View changes
dcam’s picture

dcam CreditAttribution: dcam commented
Category: Task » Bug report
Related issues: +#1395594: Feed does not display teasers, only title

I thought about this and realized this is a bug report, not a task. After all, this is a non-functional admin setting.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

@dcam since this has a migration from 6 and 7 would that need to be moved to Views trim formatter?

dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented

I thought it might need to be moved there. I mentioned it as an option in the proposed resolution, but my meaning may not have been clear.

One of the problems with this configuration setting is the ambiguity about what it does. I imagine that if we moved it to the trim formatter's setting in Views, then it would no longer need to be part of the Aggregator config form. Removing it would solve the ambiguity problem.

Anyway, if this setting is considered important to retain, then yes it seems like the thing to do is move it into the Views field formatter.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Project: Drupal core » Aggregator
Version: 9.3.x-dev » 1.x-dev
Component: aggregator.module » Code

The aggregator module has been removed from Core in 10.0.x-dev and now lives on as a contrib module.
Issues in the Core queue about the aggregator module, like this one, have been moved to the contrib module queue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Category: Bug report » Task
Priority: Normal » Minor
dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented
Status: Active » Needs review
FileSize
2283877-17.patch8.08 KB

I'm biased because I created this issue, but I still think this is a bug. teaser_length is a non-functional admin setting. But it's not worth arguing over. We only need to decide what to do about it.

I'm in favor of eliminating the setting entirely with no further action. As I've become more familiar with this module over the past few months and studied it again tonight, I've come to believe that there isn't any place that we can migrate this setting into. The entity views and Views don't utilize formatters with options. We would have to add something in order to make it do something. It has been non-functional for 8 years. Let's allow it to die quietly. Here's a patch.

dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented
Version: 1.x-dev » 2.x-dev
dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented 
+++ b/tests/src/Functional/Update/AggregatorUpdateDeleteTeaserLengthSettingTest.php
@@ -0,0 +1,33 @@
+  /**
+   * Ensure all items in the aggregator_feeds queue are deleted.
+   */
+  public function testUpdateHookN(): void {

I forgot to update this docblock when I copied it from another test I'd written. But I'm not going to bother changing it right now. We'll probably have to update this class's docblock to change the number of the update function it covers anyway. It can be fixed then.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Good to go too after re-roll and fixing comment per #19

dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
2283877-21.patch8.16 KB

Rerolled since the update function number has to be updated.

  • dcam committed 01819a66 on 2.x 
    Issue #2283877 by dcam, larowlan: Remove or use Aggregator's...
dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented
Version: 2.x-dev » 1.x-dev
dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented
FileSize
2283877-24.patch8.13 KB

Rerolled for the 1.x branch.

  • dcam committed a5b6ea96 on 1.x 
    Issue #2283877 by dcam, larowlan: Remove or use Aggregator's...
dcam’s picture

dcam CreditAttribution: dcam as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.