Problem/Motivation

#1921544: Create a Current Path Condition added a new condition plugin that tries to use the path.alias_manager.cached service.
However, that service was renamed in #2233623: Merge AliasManagerCacheDecorator into AliasManager.

It's not failing any tests because the test explicitly sets up the class with the wrong service name.

Proposed resolution

Fix the service name.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#1 request-path-2283061-1.patch1.43 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
request-path-2283061-1.patch1.43 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

That's the problem with those manually set up (unit) tests :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed c4728bc and pushed to 8.x. Thanks!

  • Commit c4728bc on 8.x by alexpott: 
    Issue #2283061 by tim.plunkett: Fixed RequestPath condition uses non-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.