Problem/Motivation

Contributor links box has links that are of questionable utility to contributors

Proposed resolution

  • Novice issues link should filter to only "active" "needs work" and "needs review"
  • Link to the new contributor tasks documentation page https://drupal.org/new-contributors
    • link to /getting-involved
  • remove bug bingo
  • remove patch bingo
  • remove drupal talk

Remaining tasks

User interface changes

Yes, cleaning up relevant links in contributor tasks block, but not introducing any new uswer interface pattern

Before
Before image
After
After image

API changes

No

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

realityloop’s picture

realityloop’s picture

Project: Drupal.org site moderators » Drupal.org customizations
Version: » 7.x-3.x-dev
Component: Textual improvements » Code
FileSize
2.39 KB

Patch attached

realityloop’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
47.29 KB
Xano’s picture

  1. +++ b/drupalorg_project/drupalorg_project.module
    @@ -943,6 +943,8 @@ function drupalorg_project_bingo_block_output() {
           'data' => '<strong>Queues</strong>',
    

    Can we change this to "Issue queues" for more clarity?

  2. +++ b/drupalorg_project/drupalorg_project.module
    @@ -1027,30 +1029,15 @@ function drupalorg_project_bingo_block_output() {
           'data' => '<strong>Web links</strong>',
    

    Any link points to the web, but these are special! Let's make this heading more descriptive. What about "Interact with the community" or something similar that usesthe word "community"?

realityloop’s picture

Updated patch attached

realityloop’s picture

FileSize
1.11 KB

heres the interdiff

Xano’s picture

Status: Needs review » Reviewed & tested by the community

Looks good! I'd like to confirm that this has been discussed by @YesCT and @realityloop at the Drupalcon Austin sprint, so multiple people have gone over this change.

tvn’s picture

dww’s picture

Status: Reviewed & tested by the community » Needs review

Mostly +1 to all this, thanks!

However, if memory serves me, this is the *only* place we link to the patch bingo stuff. If we're really killing those links, we should probably kill the corresponding code that provides the pages that they link to. Or are those links present in other landing pages and such on d.o outside of this block?

Also, I'm not sure that 3 people discussing this (at a sprint or via this issue) constitutes enough of a mandate for this change. But I'm out of the loop on d.o governance and teams and such. Apologies if I'm not understanding the context. :) But, personally, I'd like to see a bit more discussion/agreement before we commit/deploy.

If I'm wrong about both (quite possible) feel free to do it anyway. ;)

Thanks again,
-Derek

YesCT’s picture

Issue summary: View changes

Yeah, I looked at these changes also. And I think they are good.

Options for how to proceed...
we could git blame the addition of the things we are taking out, and find out what issue added them, and post a comment on them...
but I think it's ok to get a few thumbs up here.

I'm not sure about the reordering of the links.

Planet seems to be best thing to list first...
where those just changed to alphabetical?

And... I think there was a small change since the after picture in the summary, so we need a new after picture.

realityloop’s picture

realityloop’s picture

Issue summary: View changes
realityloop’s picture

Issue summary: View changes
YesCT’s picture

+++ b/drupalorg_project/drupalorg_project.module
@@ -943,15 +943,17 @@ function drupalorg_project_bingo_block_output() {
-      'data' => '<strong>Queues</strong>',
+      'data' => '<strong>Issue queues</strong>',

why does the screenshot still say Queues instead of Issue queues?

Bojhan’s picture

I am not going to do this without data. We really need to know how often each of these links are used. This is all based too much on a hunch on what is used and we simply do not know at this time.

Apart from that the queues section is incredibly large which makes it harder to scan. I'd prefer if we break it up in more parts.

drumm’s picture

This is in the http logs. For a recent day of logs, 11 ~people (measured by IP address) played bingo 41 times. 25 of those was one person.

(Personally, I'd like to see bingo re-done with an actual 5×5 square and a free space. But I'm not about to write all the code for that in reality.)

drumm’s picture

Except for removing bingo, this looks good to go.

I'd be on okay with removing bingo myself. Fixing a random thing in a random contrib project isn't something I'd want to ask someone to do in today's contrib. And core likes to really focus on fixing specific sets of issues, like beta blockers.

xjm’s picture

Can someone check GA to address Bojhan's question in #15? Or can we move the removal of the bingo thing to a separate issue and commit the rest?

(I'm also in favor of removing the bingo but want to try to make incremental change if we can.) :)

Bojhan’s picture

I am fine with not addressing my concern, I have asked for a GA thing before - and it just takes super long for it to be picked up. Lets proceed here without any data.

Its not something you can quickly pull out, you will need to add tracking.

drumm’s picture

#16 was meant to show the usage. It isn't used much.

xjm’s picture

Cool, so sounds like the patch is good then. What's the link to the dev site? Can we rebuild it and get current screenshots, so we can RTBC this?

  • drumm committed 15b3e09 on 7.x-3.x
    #2282517 Update queries to match dashboard link.
    
  • drumm committed 205e3d9 on 7.x-3.x authored by realityloop
    #2282517 Update/Redo Contributor Links block for Dashboard page
    
drumm’s picture

Status: Needs review » Fixed
Issue tags: +needs drupal.org deployment
drumm’s picture

Issue tags: -needs drupal.org deployment

This is now deployed on Drupal.org.

  • drumm committed 15b3e09 on 2350591-not-spammer-role
    #2282517 Update queries to match dashboard link.
    
  • drumm committed 205e3d9 on 2350591-not-spammer-role authored by realityloop
    #2282517 Update/Redo Contributor Links block for Dashboard page
    

  • drumm committed 15b3e09 on 2322267-bakery-sync-country
    #2282517 Update queries to match dashboard link.
    
  • drumm committed 205e3d9 on 2322267-bakery-sync-country authored by realityloop
    #2282517 Update/Redo Contributor Links block for Dashboard page
    

  • drumm committed 15b3e09 on random-supporter-logos
    #2282517 Update queries to match dashboard link.
    
  • drumm committed 205e3d9 on random-supporter-logos authored by realityloop
    #2282517 Update/Redo Contributor Links block for Dashboard page
    

  • drumm committed 15b3e09 on hosting-type-field
    #2282517 Update queries to match dashboard link.
    
  • drumm committed 205e3d9 on hosting-type-field authored by realityloop
    #2282517 Update/Redo Contributor Links block for Dashboard page
    

  • drumm committed 15b3e09 on filter-partners-by-sector
    #2282517 Update queries to match dashboard link.
    
  • drumm committed 205e3d9 on filter-partners-by-sector authored by realityloop
    #2282517 Update/Redo Contributor Links block for Dashboard page
    

  • drumm committed 15b3e09 on restrict-commit-issue-notifications
    #2282517 Update queries to match dashboard link.
    
  • drumm committed 205e3d9 on restrict-commit-issue-notifications authored by realityloop
    #2282517 Update/Redo Contributor Links block for Dashboard page
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.