Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.All the FIELDSET elements used in forms are now HTML 5 DETAILS -- change record here: https://drupal.org/node/1852020
The styling for fieldsets needs to be updated to retain a consistent look as far as possible.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2282365.garland.fieldset-details.patch | 2.24 KB | joachim |
| #4 | garland-fieldsets-d7.png | 36.82 KB | joachim |
| #2 | garland_fieldset.png | 71.97 KB | Manjit.Singh |
| #1 | garland-details.png | 45.34 KB | joachim |
Comments
Comment #1
joachim CreditAttribution: joachim commentedOne problem is that the way in which the fieldset title is set into the fieldset border. With actual fieldset elements, that's done for us by the browser. Garland's styling just adds a bit of colour and a fancy expand/collapse icon.
With details/summary, we have to use CSS to position the summary (the former fieldset title) into its border. That's doable, but we then have to cover up that part of the border. That would normally be doable too, but Garland's gradient backgrounds make that pretty much impossible: it's very easy for a details/summary set to be at the top of the content area, with a gradient behind it.
So the best I think that can be done is to extend the border to go around the summary, so that it can have a solid background. Here's a screenshot. My CSS for this still needs some tidying up.
The alternative is to totally ditch the Garland style for details, and do something more like what Bartik has.
Comment #2
Manjit.SinghCurrent fieldset is looks good :) Attaching screenshot.
Comment #3
joachim CreditAttribution: joachim commentedAgreed, they're ok as they are, but I think it would be nice to try to preserve the styling they had in earlier versions.
Here's a D7 screenshot for reference.
Comment #4
joachim CreditAttribution: joachim commentedOops. Here's that screenshot again: Garland fieldsets on D7.
Comment #5
joachim CreditAttribution: joachim commentedHere's a patch that styles DETAILS like the screenshot in #1.
Comment #6
joachim CreditAttribution: joachim commentedNo reviews, and patch is in danger of rotting if I work on other fixes, so I'm making an executive decision and committing it :)