Problem/Motivation

After running the comment migration as described in the parent issue, I end up with comments that are not attached to entities. The node types themselves don't end up with any "comment fields" on them. (I'm still new to the D8 comment configuration, so didn't do any pre-configuration of the D8 site, but presume this should work even when done on a fresh D8 install?) If I try to manually edit one of the comments on /admin/content/comment, I get this PHP error:
PHP Fatal error: Call to a member function getSetting() on a non-object in .../core/modules/comment/src/CommentForm.php on line 86

If relevant, the "field_id" column in the D8 comments table for the imported comments is: node__comment

Proposed resolution

Make sure that the comment fields are created before comments are migrated. Hopefully this will fix the unattached comments problem.

Remaining tasks

  • Confirm that fix is a good idea
  • Implement that fix

User interface changes

API changes

Comments

brockfanning’s picture

brockfanning CreditAttribution: brockfanning commented
Issue summary: View changes
benjy’s picture

benjy CreditAttribution: benjy commented

Would be great if we could test this again? Also, not sure if this could be related #2340401: Fill commented entity during stub comment saving

jcost’s picture

jcost CreditAttribution: jcost commented
Parent issue: #2224085: Manual Testing: D6 Comments » #2462627: [META] Drupal 6 to Drupal 8 Migration path
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Active » Closed (cannot reproduce)

This apparently was fixed somewhere along the way.