In a clean D6 site

Created Event content type and changed some default settings. The Workflow settings were changed to:

[ ] Published
[ ] Promoted to front page
[x] Sticky at top of lists
[x] Create new revision

After migrating to a clean D8 site

The Publishing options in the new Event content type maintained default values. The changed values were not migrated over.

[x] Published
[x] Promoted to front page
[ ] Sticky at top of lists
[ ] Create new revision

CommentFileSizeAuthor
#5 2281443-5.patch6 KBultimike
#5 interdiff.txt5.27 KBultimike
#4 interdiff.txt4.86 KBultimike
#4 2281443-4.patch5.6 KBultimike
#2 migrate_drupal-publishing-options-test-2281443.patch2.7 KBTommyK
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TommyK’s picture

TommyK CreditAttribution: TommyK commented
Parent issue: » #2222375: Manual Testing: Nodes
TommyK’s picture

TommyK CreditAttribution: TommyK commented
FileSize
migrate_drupal-publishing-options-test-2281443.patch2.7 KB

Added a patch to show the tests that fail.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented
Status: Active » Needs work
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented
FileSize
2281443-4.patch5.6 KB
interdiff.txt4.86 KB

I banged on this one for a bit tonight, to no avail. I think the issue lies somewhere in the d6_node_type.yml file - mapping the options to settings.node.options, maybe?

I think I found and fixed some bugs in the test, but haven't solved the root issue yet.

Updated patch and interdiff attached.

Thanks,
-mike

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented
Status: Needs work » Needs review
FileSize
interdiff.txt5.27 KB
2281443-5.patch6 KB

Ok - I think this one is ready for review. I found and fixed the bug and improved the MigrateNodeTypeTest.

I ran the MigrateNodeTypeTest and a manual test locally, and both are looking good.

Thanks,
-mike

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs review » Reviewed & tested by the community

Patch looks good to me.

chx’s picture

chx CreditAttribution: chx commented 
-      $options[$item] = isset($options[$item]);
+      $options[$item] = in_array($item, $source_options);

compared to D6variable_get('node_options_'. $type->type, array('status', 'promote')), that looks, indeed correct! Very nice catch.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

  • Dries committed d1f6df1 on 8.x 
    Issue #2281443 by ultimike, TommyK: Fixed D6 Workflow settings -> D8...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.