Comments

ndewhurst’s picture

ndewhurst
he/him
Primary language English
Location USA
CreditAttribution: ndewhurst commented
Assigned: Unassigned » ndewhurst
Status: Active » Needs work
ndewhurst’s picture

ndewhurst
he/him
Primary language English
Location USA
CreditAttribution: ndewhurst commented
Assigned: ndewhurst » Unassigned
Status: Needs work » Needs review

Pushed to GitHub for review.
See pull request here: https://github.com/fago/rules/pull/56

ndewhurst’s picture

ndewhurst
he/him
Primary language English
Location USA
CreditAttribution: ndewhurst commented
Assigned: Unassigned » ndewhurst
ndewhurst’s picture

ndewhurst
he/him
Primary language English
Location USA
CreditAttribution: ndewhurst commented
Status: Needs review » Needs work
ndewhurst’s picture

ndewhurst
he/him
Primary language English
Location USA
CreditAttribution: ndewhurst commented
Status: Needs work » Needs review

I revised the code based on fubhy's/fago's comments, and updated the Github feature branch/pull request.

fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs review » Fixed

Thanks! Merged

  • Commit 6d21f17 on 8.x-3.x authored by ndewhurst, committed by fubhy: 
    Issue #2281109: Porting 'Entity is of type (entity_is_of_type)'...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.