In the pane settings modal overlay, the Save (submit) button is the very first form control in the form. The submit button should be after all of the form controls and instructions in tab order and source code order. CSS positioning could be used to keep the button in its current location.

CommentFileSizeAuthor
#5 2280883-save-button-order-1.patch3.29 KBdnmurray
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cboyden’s picture

cboyden CreditAttribution: cboyden commented
Related issues: -#2280879: [META] Customize this page: Accessibility issues
dnmurray’s picture

dnmurray CreditAttribution: dnmurray commented
Assigned: Unassigned » dnmurray

Working on this at the sprint.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

@dnmurray: Can you post the in-progress patch that you made at the sprint? Even if it's not finished and you plan to keep working on it, it'd be great to have it in the queue! :-)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Component: User interface » Magic

Changing to "Magic" because this is in panopoly_magic.

dnmurray’s picture

dnmurray CreditAttribution: dnmurray commented
FileSize
2280883-save-button-order-1.patch3.29 KB

The attached patch fixes part of the problem, on some edit panes. Well, I'm not sure "fix" is appropriate, since I can't seem to be able to tab to the button at all. The patch moves the order of the button set to the end of the form. It also (tries) to wrap the left side of the pane in a div so it can be left-aligned in a fixed-width area. The buttons then naturally appear below the preview pane.

@dsnopek emacs stripped a bunch of whitespace from the files. I did a `git diff -b` to prevent that from appearing in the patch. Just an fyi for future submissions, as a way to prevent massive amounts of meaningless patch review.

This patch doesn't work for most of the "add" panes. The Content Settings fieldset is not added by the magic module. My next step was to go try and figure out how to trap the form after those fields were added. This patch needs a lot more work.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Thanks! :-)

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Active » Needs review

Just changing the status to get reviews.

arknoll’s picture

arknoll CreditAttribution: arknoll commented

I am trying to figure out what the driver is to have these buttons at the top of the form. This seems to make it confusing for editors when there is a longer edit screen in the modal.

How about attempting to fix the position of the action buttons to the bottom of the modal? This would potentially require js.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

I am trying to figure out what the driver is to have these buttons at the top of the form. This seems to make it confusing for editors when there is a longer edit screen in the modal.

It's so that we can float them right and have them appear in the right-hand column underneath the preview.