Problem/Motivation

The hook_help implementation for the User module (function user_help() in user.module) has two relatively minor issues that should be fixed:

Proposed resolution

  1. Inconsistent headers in its Uses section. They should all start with -ing verbs, but some do and some don't. Example "User roles" should probably be "Configuring user roles".
  2. In the first Uses item about creating and managing users, it says "By editing one particular user you change the username, e-mail address, and password.". This is accurate, but incomplete -- you can edit all the fields. So we should say something more like "you can change their user name, email address, password, and information in other fields".

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Update the issue summary Novice Instructions
Create a patch Instructions

User interface changes

API changes

Original report by @jhodgdon

The hook_help implementation for the User module (function user_help() in user.module) has two relatively minor issues that should be fixed:

a) Inconsistent headers in its Uses section. They should all start with -ing verbs, but some do and some don't. Example "User roles" should probably be "Configuring user roles".

b) In the first Uses item about creating and managing users, it says "By editing one particular user you change the username, e-mail address, and password.". This is accurate, but incomplete -- you can edit all the fields. So we should say something more like "you can change their user name, email address, password, and information in other fields".

Files: 
CommentFileSizeAuthor
#11 after.png149.73 KBjonreid
#11 before.png135.54 KBjonreid
#10 user_module_help_needs-2280521-10.patch8.18 KBmparker17
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,752 pass(es).
[ View ]

Comments

jhodgdon’s picture

theMusician’s picture

Issue summary:View changes
theMusician’s picture

Issue summary:View changes
theMusician’s picture

Issue summary:View changes
jhodgdon’s picture

theMusician: Um... This is way more complicated than we need. We don't need any before/after screenshots. The issue summary already seems way over the top... We just need a quick patch.

theMusician’s picture

Issue summary:View changes

No problem jhodgdon, just getting ready some issues for the Austin sprint. That is fine with me if before/after screenshots are not needed. I certainly do not want this to turn into our favorite issue, https://drupal.org/node/950534 :p

mparker17’s picture

Assigned:Unassigned» mparker17

As discussed in #1952064-40: Shorten help text on User Roles page, I'm going to do this.

mparker17’s picture

StatusFileSize
new7.95 KB

See the attached patch for the changes made to user_help() in #1952064-37: Shorten help text on User Roles page EXCEPT the changes made to case 'user.role_list' (which are in #1952064-41: Shorten help text on User Roles page). I did not make any changes to the text from the patch in that comment; I just split out these segments.

Note that @jhodgdon's comments in #1952064-36: Shorten help text on User Roles page have been addressed in this patch.

mparker17’s picture

Status:Active» Needs work

Still have to address:

a) Inconsistent headers in its Uses section. They should all start with -ing verbs, but some do and some don't. Example "User roles" should probably be "Configuring user roles".

b) In the first Uses item about creating and managing users, it says "By editing one particular user you change the username, e-mail address, and password.". This is accurate, but incomplete -- you can edit all the fields. So we should say something more like "you can change their user name, email address, password, and information in other fields".

mparker17’s picture

Assigned:mparker17» Unassigned
Status:Needs work» Needs review
StatusFileSize
new8.18 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,752 pass(es).
[ View ]
new3.81 KB

Okay, attached is a patch that addresses those issues.

jonreid’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new135.54 KB
new149.73 KB
dbcollies’s picture

I can confirm that the patch applied cleanly and worked as indicated.

jonreid's screen shots match what I found

jhodgdon’s picture

Status:Reviewed & tested by the community» Fixed

Thanks all, that was quick! Committed to 8.x.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.