Problem/Motivation

Currently the condition in omega_extension_enabled() basically just allows variables set in the settings.php do disable already enabled theme settings.
This means I can disable Enable Development extension by using $conf['omega_toggle_extension_development'] = FALSE; in settings.php but I can't enable it (No not even if I use $conf['omega_toggle_extension_development'] = TRUE;) ;).

Proposed resolution

Change the condition in omega_extension_enabled() as proposed in the attached patch.
Tests look positive so far.

Remaining tasks

Reviews needed

User interface changes

None

API changes

None

CommentFileSizeAuthor
#2 omega-allow-enabling-extensions-by-variable-override-2279669-2.patch1005 bytesdas-peter
omega-allow-enabling-extensions-by-variable-override.patch845 bytesdas-peter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fubhy’s picture

fubhy CreditAttribution: fubhy commented

Can we make that a little simpler? Like so:


if (($extensions = omega_extensions($theme)) && isset($extensions[$extension])) {
  if (!variable_get('omega_toggle_extension_' . $extension, FALSE) || !empty($extensions[$extension]['errors'])) {
    return FALSE;
  }
  
  return !empty($extensions[$extension]['enabled']) && variable_get('omega_toggle_extension_' . $extension, TRUE);
}
das-peter’s picture

das-peter CreditAttribution: das-peter commented
FileSize
omega-allow-enabling-extensions-by-variable-override-2279669-2.patch1005 bytes

Adjusted patch.

fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs review » Fixed

  • Commit d151c47 on 7.x-4.x authored by das-peter, committed by fubhy: 
    Issue #2279669 by das-peter: Added Allow enabling override in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.