Problem:

search_excerpt() uses "..." instead of "…" (individual dots instead of Unicode ellipsis character).

Solution:

Use "…" in search_excerpt() instead.

To repliccate:

  • Add a blog post with a lot of content
  • Run cron to see that the page is indexed
  • Search for the page
  • Look for the ... prefixing the exerpted contect
CommentFileSizeAuthor
#2 Post-patch-ellipsis.png98.9 KBmgifford
#2 Pre-patch-ellipsis.png127.79 KBmgifford
#1 2279623-1.patch1.13 KBthedavidmeister
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Active » Needs review
FileSize
2279623-1.patch1.13 KB
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue summary: View changes
Issue tags: +typography
FileSize
Pre-patch-ellipsis.png127.79 KB
Post-patch-ellipsis.png98.9 KB

Nice patch. Here's the before image:

And after the patch:

Basically this won't make a big difference for most, but for folks who care about typography this is an important improvement.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented

RTBC then?

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs review » Reviewed & tested by the community

Yes. I think so.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs review

Why not … instead of the unicode character?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs review » Reviewed & tested by the community

To answer my own question #44987: [meta] Use the UTF-8 ellipsis character instead of "..." in the user interface which I would have seen if I looked in the related issues.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 686e1da and pushed to 8.x. Thanks!

  • Commit 686e1da on 8.x by alexpott: 
    Issue #2279623 by thedavidmeister: Fixed search_excerpt() should use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.