Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.All our old tpl.php files need to be converted to twig.
I'm working on page.tpl.php currently.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2279505.garland.tipplefip-to-twig.patch | 42.11 KB | joachim |
Comments
Comment #1
joachim CreditAttribution: joachim commentedA number of tweaks have been needed in addition to a straight conversion:
* Removed garland_process_html() and garland_process_page() as _color_html_alter() and _color_page_alter() seem to be obsolete. -- AFAICT, color module hooks into the theme without us needing these functions any more.
* Fixed styling for comment 'new' indicator getting applied to whole comment -- core seems to now apply the 'new' CSS class to the whole comment, and so our styles intended for just the 'new' marker were getting applied to the whole comment and causing havok.
* Added zebra class to garland_preprocess_comment(), as core no longer seems to take care of this. -- AFAICT core no longer adds a zebra class ('odd'/'even'), so I've added code here to provide it on comments, as our comment.tpl.php outputs on D7. However, there don't seem to be any styles in Garland for this anyway!
* Removed theme_breadcrumb(): now taken care of by the theme system. -- this was adding extra markup for the benefit of screen readers. This is now done by core.
* Added sidebar body CSS classes to page preprocessor (core seems to no longer provide them) -- on the other hand, core no longer provides body classes to indicate the number of sidebars that are present, so we have to do that. Code copied from Bartik :)
Comment #2
joachim CreditAttribution: joachim commentedComment #3
joachim CreditAttribution: joachim commentedPS. Haven't included the maintenance tpl file in this, as it looks fairly complicated, and it's not an essential!