Code Comments in View's Route Subscriber Test are inaccurate.

CommentFileSizeAuthor
#1 drupal-2278037-1.patch1016 bytesconnorwk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

connorwk’s picture

connorwk CreditAttribution: connorwk commented
Status: Active » Needs review
FileSize
drupal-2278037-1.patch1016 bytes
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Title: Code Comments in View's Route Subscriber Test are inaccurate » Code comments in View's RouteSubscriberTest are inaccurate
Status: Needs review » Reviewed & tested by the community
Issue tags: +Novice

This looks good. The original docblock was outdated and the fix introduces PHPUnit annotations, which is a welcome additional improvement. RTBC if the tests pass.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed fa47d45 and pushed to 8.x. Thanks!

  • Commit fa47d45 on 8.x by alexpott: 
    Issue #2278037 by connork: Fixed Code comments in View's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.