Currently all non-ASCII characters in menu link titles are skipped when generating the menu link identifier. This makes importing menu links in non-latin languages almost impossible. The Transliteration module allows to convert these characters to ASCII combinations, so integrating with it allows to support non-latin links.

CommentFileSizeAuthor
#4 features-menu_link_transliteration-2277377-4.patch851 bytesmarco
#3 features-menu_link_transliteration-2277377-3.patch889 bytesplach
#1 features-menu_link_transliteration-2277377-1.patch671 bytesplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Active » Needs review
FileSize
features-menu_link_transliteration-2277377-1.patch671 bytes
hefox’s picture

hefox CreditAttribution: hefox commented
Status: Needs review » Needs work

Could you update the code comment to expand on what this is doing, or at least mention what module it is coming from? Also, perhaps check for module instead of function? I very between which is better to check, but I think in this case module may be better (in case module is disabled but loaded? functions it has shouldn't be taken effect in that case? meh).

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Needs review
FileSize
features-menu_link_transliteration-2277377-3.patch889 bytes

And here it is

marco’s picture

marco CreditAttribution: marco at Tag1 Consulting commented
FileSize
features-menu_link_transliteration-2277377-4.patch851 bytes

Updated to the latest stable. We've been using this since the original patch.

Status: Needs review » Needs work

The last submitted patch, 4: features-menu_link_transliteration-2277377-4.patch, failed testing. View results