Hi,
Something that may frustrate a lot of people is the fact that the default token trees do not go beyond 4 depth levels, such that the new style options will never be shown in the token trees when the image is in a deep sub-group (e.g. message: user:main-profile:profile_image). Modifying the recursion level above 4 will often result in a WSOD due to out of memory failures in many setups so this isn't a viable option. The tokens with more than 4 levels (i.e. a:b:c:d:e and above) can still be typed in manually however so this module is of course still useful/useable.
Until lazy loading is standardized in tokens (https://drupal.org/node/1334456) it might be useful to advertise this likely occurrence/frustration.
Comment | File | Size | Author |
---|---|---|---|
#6 | imagecache_token-n2277125-6.patch | 1.34 KB | DamienMcKenna |
|
Comments
Comment #1
DamienMcKennaI'm not sure what to do in this scenario - should a help message be added via a theme preprocess function into the token browser?
Comment #2
cmonnow CreditAttribution: cmonnow commentedYeah it's a complicated issue. I think a helpful explanation can be added to the token browser (which may have to be generalised since the Token tweaks module may alter the depth in $variables['recursion_limit']).
From a UI point of view this would be a useability flaw that would probably be more appropriately tackled by the Token module itself (which isn't promising, considering the unlikelihood of a depth-on-demand or autocomplete AJAX-based UI anytime soon in Drupal 8 core). To be honest I don't even know how deep trees should behave in responsive designs, let alone under the multitude of devices (and input methods).
Comment #3
DamienMcKennaMoving this to the Token module as it's a problem with the module's browser, not so much the Imagecache Token module, BICBW and please let me know if I am.
Comment #4
Dave ReidWe can't expand more than four levels due to performance reasons. I would suggest following #1334456: Enable ajax on-demand loading of sub-trees in the Token help which is the best chance at resolving this for items with depth more than 4.
Comment #5
DamienMcKennaOk, lets move this back to the Imagecache Token queue and we'll document the problem in the README.txt file.
Comment #6
DamienMcKennaComment #8
DamienMcKennaCommitted.