[D7] Commerce Heureka - conversions and verified by customers tracking

It doesn't pass pareview: http://pareview.sh/pareview/httpgitdrupalorgsandboxbrnco2271805git

On line 78 of the .module file you don't actually check if the request succeeded, so you don't need the $result variable.
However is would be better if you checked the response.

on Line 154 of the .module file shouldn't is be better to use drupal_add_js?

the .info file misses dependencies?
Also there is no core=7.x to tell Drupal that it is for D7.

Forgot to change the status.

It still doesn't pass pareview: http://pareview.sh/pareview/httpgitdrupalorgsandboxbrnco2271805git

You only have a master branch and not a 7.x-1.x branch.
Your project page lacks content. It doesn't say what Heureka is, and how it should be used. Also it doesn't have a link to the heureka.sk or heureka.cz

I am sorry that I didn't mention this the first time, but I am also new to this reviewing ;)

Looks good to me.

Hello brnco,

How commerce_heureka_pane_checkout_form function is called? is this a hook!? hook_pane_checkout_form doesn't exists unless I am mistaken.

Sorry, brnco, that's not how it works.

Please note that you're not supposed to change the status to to Reviewed & tested by the community" (RTBC) yourself.

After you think you've fixed all the problems pointed out in a review, you change the status from "Needs work" to "Needs review". This indicates that you think the project is ready for a new review. You're not supposed to review your own project.

After the reviewer has had time to review the new version, he or she has two main options: To point out that there are still points that need to fixed, and set the status to "Needs work". Or to set the status to "Reviewed & tested by the community" to indicate that the reviewer now thinks the project is ready to be promoted into a full project. Note that this status in no guarantee of promotion. There may be other reviewers that disagree, and that may push it back down to "Needs work".

Also: The automated review of your project by PAReview has found some issues with your code. As coding standards make sure projects are coded in a consistent style we ask you to please have a look at the report and try to fix them.

There is no git clone command in your issue summary. There is a git link, but that is not the same as a git clone command.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

The code comes back clean from PAreview. I checked the sources and only one thing grabbed my attention: The function "commerce_heureka_pane_checkout_form" implements a Drupal Commerce API hook, but does not declare this fact in the comment. The comment should probably comply with the standard form declaring what it implements and what the parameters are used for.

Other than that, I see nothing that needs attention.

Automated Review

Review of the 7.x-1.x branch (commit 1aa0887):

No issues found.

Manual Review

Individual user account

Yes.

No duplication

Yes. Does not cause module duplication or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code (no 3rd party code found).

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and the README Template. The README does not follow the template structure. However, some of the sections are not necessary for this module so I don't think this is a problem.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes. If "no", list security issues identified.

Coding style & Drupal API usage

1. Only one minor issue: commerce_heureka_pane_checkout_form implements hook_pane_checkout_form from the drupal_commerce api and should be annotated accordingly.

Non-blocking issues:

• In commerce_heureka_prepare_transfer_url() the use of LANGUAGE_NONE will not support multi-lingual commerce sites. Consider using the Entity API and entity_metadata_wrapper() to access those fields
• In commerce_heureka_pane_checkout_form() it would be much cleaner to use drupal_add_js() and Drupal.settings to include that javascript
• In commerce_heureka_settings_form_validate() your error messages could be more informative. Also maybe a length check to make sure the keys are the right size?
• The readme and project page could use more info

Checked for security, licensing, duplication, use of Drupal API, and individual account, no issues found.

Thanks for your contribution, brnco!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.