Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
- Text editors can open dialogs e.g. to upload and insert images into the text.
- Views UI opens dialogs for its various sub-forms.
Given these facts it is easy to imagine a situation where a dialog would be opened from within a dialog. When that happens things go horribly wrong. The inner dialog takes over and the parent dialog is lost. I.e. with a text editor inside of a Views UI dialog, you can successfully open the inner dialog and even upload an image, but you cannot insert it back into the text in the parent dialog, as that dialog is no longer there.
This would be the case for the Header/Footer/Empty texts in Views UI (in which case this would be a bug) if Views UI did not explicitly disable text editor support in its dialogs.
Complex UIs in contrib will probably run into the same problem, i.e. Rules/Panels/... Forcing all such modules to disable text editor support in dialogs is a bad solution to the problem.
Proposed resolution
?
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2272369-dialog-broken-views-do-not-test.patch | 1.4 KB | tstoeckler |
Comments
Comment #1
tstoecklerTo reproduce this problem you can apply this patch and edit the Empty/Footer/Header text for a view and try to insert an image with CKEditor.
Comment #2
nod_Comment #3
nod_Comment #14
catchMarking duplicate of #2984865: Data is not saved in case of nested dialogs in CKEditor. I think this is solved for the ckeditor case with ckeditor5, which doesn't use dialogs.