Replace theme_metatag_opengraph with theme_metatag_property that is part of the core module, there's may be other meta tags that use the 'property' attribute. Also streamline metatag_opengraph_metatag_info() by assigning default values that are added to each item, rather than duplicating so much code.

CommentFileSizeAuthor
#1 metatag-n2271811-1.patch12.66 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
FileSize
metatag-n2271811-1.patch12.66 KB

This makes the following changes:

  • I removed theme_metatag_opengraph and instead added theme_metatag_property, and updated all OG meta tags to use the new function.
  • I simplified the OG meta tag definitions by using a set of common default values that was appended, rather than needlessly duplicating five lines for each one.
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed.

  • Commit 4164a2f on 7.x-1.x by DamienMcKenna: 
    Issue #2271811 by DamienMcKenna: Replaced theme_metatag_opengraph() with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.