I'm the maintainer of the webform_confirm_email module and I'm asking for a change in the webform report code. I want to provide the users of my module the option to filter for confirmed/unconfirmed webform submissions in the Results -> Submissions and Results -> Download part.

The attached patch extends the code in that it adds a $filters parameter to some functions in order to filter for (un)confirmed submissions. If you accept the patch it would significantly reduce the amount of code I have to copy from webfrom into my module.

best regards

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

matthias_mo’s picture

DanChadwick’s picture

Version: 7.x-3.x-dev » 7.x-4.x-dev

New development is happening in the 7.x-4.x branch.

I believe there is the intention to adopt views to replace the reporting that webform does. Views could perhaps also be used for downloading. I wonder if the effort might better be directed there?

matthias_mo’s picture

I can't recommend where to direct the effort. What I can tell you is that most sites that are using my module are using the webform-7.x-3.x version of it and I expect that to stay for some time.

For the module I'm maintaining the feature to filter the results is relatively important, hence I will include it in any case for the versions building on webform-7.x-3.x.
I currently have 2 implementations for this results filtering for my module: One version that copies quite some code from webform into my module and doesn't need any change in webform, and a second version that needs above patch for webform-7.x-3.x and that needs considerably less code for the same result.

Obviously I'd prefer if my patch for webform would be accepted (or accepted in a modified way) but if it's not possible I'll provide the filtering in my module with the copied code.

DanChadwick’s picture

Status: Active » Closed (won't fix)

Results now uses views, which can be altered or customized on a global, content type, or NID basis.