Port "Content is promoted" condition to 8.x [#2269565]

Comment #1

omissis CreditAttribution: omissis commented 17 May 2014 at 13:31

Parent issue:

» #2269561: [META] Port all conditions to 8.x

Log in or register to post comments

Comment #2

omissis CreditAttribution: omissis commented 17 May 2014 at 13:35

Title:

Content is promoted

» Implement "Content is promoted" Condition

Look at the Drupal\node\Plugin\Condition\NodeType class (a core condition) and Drupal\condition\Tests\Condition\NodeConditionTest.

Compared to the core NodeType condition, we do not use configuration or configuration forms yet, but specify all parameters as context for now, as the form stuff is still to be figured out.

Log in or register to post comments

Comment #3

fago

German

Vienna

CreditAttribution: fago commented 17 May 2014 at 15:29

Title:

Implement "Content is promoted" Condition

» Port "Content is promoted" condition to 8.x

improving title

Log in or register to post comments

Comment #4

omissis CreditAttribution: omissis commented 17 May 2014 at 15:48

Status:

Active

» Needs review

Implemented in https://github.com/fago/rules/pull/6

Log in or register to post comments

Comment #5

omissis CreditAttribution: omissis commented 17 May 2014 at 15:48

Assigned:

omissis

» Unassigned

Log in or register to post comments

Comment #6

fago

German

Vienna

CreditAttribution: fago commented 18 May 2014 at 10:14

Status:

Needs review

» Needs work

Thanks. Setting to needs work as you are still working on the tests.

Log in or register to post comments

Comment #7

paranojik CreditAttribution: paranojik commented 30 May 2014 at 09:04

Status:

Needs work

» Needs review

I went with a simpler implementation following the example of other conditions: https://github.com/fago/rules/pull/29. Happy to go with the way @omissis did it, I just need to understand the difference - which way thing are done best.