Ran into an odd issue with the field_collection module today. Steps to reproduce:

  1. Created a content type called "Event"
  2. Added a Field Collection called "Date and Location" which had a popup calendar for the date field, and an autofill form field for Location (based on entity reference).
  3. Set the field_collection widget type to "Hidden" and linked it to the "Event" content type.
  4. Saved the content type and attempted to enter data. Silent fail - not even an error message.
  5. Changed the field_collection widget type to "Embedded" - worked like a charm.

So somewhere within the field_collection module, we're seeing a conflict with the wetkit distro. This behavior isn't reproducible on a plain jane D7 install.

Comments

sylus’s picture

Assigned: Unassigned » sylus

I took a look at this issue and was able to reproduce.

Since you mentioned you weren't able to reproduce on a vanilla drupal install at first guess I think this might have something to do one with the patches we leverage for entity translation.

projects[field_collection][patch][1344672] = http://drupal.org/files/issues/field_collection-et-1344672-187.patch

Will look into this further. Thanks for the report.

sylus’s picture

Status: Active » Needs work

At long last it looks like there is a fix for this, will be updating this issue shortly.

joseph.olstad’s picture

will get into 1.9 / 4.0 ?

sylus’s picture

Nah is going to need testing, I am going to focus on release and we can tackle this one for next release.

sylus’s picture

Status: Needs work » Needs review

Okay good news is the related issue is RBTC upstream and seems to fix all known issues. We can possibly close this issue, but I'd like to create a behat test so doesn't regress.

sylus’s picture

Status: Needs review » Needs work
joseph.olstad’s picture

There was an update upstream , patch 459, can we run this through ci / behat?

sylus’s picture

Issue tags: +needs behat tests

Sure issue looks like it is close to being committed. We should also add a field collection specfic behat test while were at it.

sylus’s picture

Does the latest patch apply against the latest stable release? I'd rather change from git sha to an official release.

joseph.olstad’s picture

The latest patch applies against the dev build 2015-Mar-26 c0a4425.

If they commit this patch I'm sure it will be tagged as the next stable release.

They're holding back on a release until this patch is committed.

sylus’s picture

K will wait for next official release but can start writing behat tests now.

joseph.olstad’s picture

Just FYI, I tested a vanilla install of wetkit 4x dev with field_collection latest dev with patch 459 and the other two patches that we previously applied and all my tests so far have shown that it's working very well.

Here's the patches I'm using:

- http://drupal.org/files/issues/field_collection-add_entity_translation_support-1344672-459.patch
- http://drupal.org/files/issues/field_collection-field_collection_uuid-2075325-3.patch
- http://drupal.org/files/issues/migration_field_collection-2298877-02.patch

applied to git hash c0a4425 of field_collection

Looks good. I am trying to push this forward upstream, so far it's looking like the patch is good. They should commit the thing ASAP and if there's anything else just handle it in a NEW issue. I hope that the maintainers upstream move on this soon.

joseph.olstad’s picture

Still some work to be done upstream, but it seems like just an "edge case" is remaining. I'd say the newer patch 459 would be an improvement.

joseph.olstad’s picture

I spent quite a bit of time debugging the latest patch upstream but couldn't figure out the unlimited field collections issues.
I'm not sure if this will be fixed in time for the D8 version as they've already started porting it over to D8 and now the patch would have to get ported to D8 first as D8 is set to release in a few days.

sylus’s picture

Version: 7.x-1.4 » 7.x-4.x-dev
sylus’s picture

sylus’s picture

Status: Needs work » Closed (duplicate)

Updated the Field Collection to latest official and most recent of the entity translation patch. This should now fix issues related to field_collection and the issue related to embedding as there were additional checks added in the patch since the earlier one we were using.

See the related issue:

#2634328: Updates to Field Collection module + UUID / Deploy

apaderno’s picture

Issue tags: -needs behat tests +Needs tests