The menu link reparenting logic in menu link module is currently broken. Compare MenuLink::preDelete to _menu_delete_item in D7. The patch is outdated. Needs work/reroll ..

CommentFileSizeAuthor
#1 fix-menu-link-reparenting-logic-2266629-1.patch756 bytesAndyThornton
fix-menu-link-reparenting-logic.patch857 byteswebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AndyThornton’s picture

AndyThornton CreditAttribution: AndyThornton commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
fix-menu-link-reparenting-logic-2266629-1.patch756 bytes

The patch was not applying because the file had moved. I rerolled it.

AndyThornton’s picture

AndyThornton CreditAttribution: AndyThornton commented
Status: Needs review » Postponed

@pwolanin suggest I postpone this or mark as duplicate because of the refactoring being done in https://drupal.org/node/2256521

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Related issues: +#2256521: [META] New plan, Phase 2: Implement menu links as plugins, including static admin links and views, and custom links with menu_link_content entity, all managed via menu_ui module
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
Status: Postponed » Needs review

mgifford queued 1: fix-menu-link-reparenting-logic-2266629-1.patch for re-testing.

The last submitted patch, fix-menu-link-reparenting-logic.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 1: fix-menu-link-reparenting-logic-2266629-1.patch, failed testing.

The last submitted patch, fix-menu-link-reparenting-logic.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Fixed

We rewrote the entire thing in the meantime, so this is fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.