Audio Sampling Command Incorrect. Should be -ar instead of -ab [#2265757]

Comment	File	Size	Author
	audio_sampling.patch	536 bytes	RyanPrice

Comment #1

brycefisherfleig CreditAttribution: brycefisherfleig commented 6 June 2014 at 19:24

Hi RyanPrice,

This is the first cleanly-applying patch I have received as maintainer of this module. Thanks!!

Unfortunately, phpvideotoolkit (which your patch modifies) is an external library to the video module. Apparently, we've already made significant changes to this library, so I'm open to accepting another change here.

The phpvideotoolkit has been completely rewritten and is now maintained on github by the original author:
https://github.com/buggedcom/phpvideotoolkit-v2

I'd like to look at refactoring this module to rely on the new and improved phpvideotoolkit library -- hopefully, we can contribute fixes we need back to that project #2281595: Consider PHPVideoToolkit V2

For the time being, can you explain what problem this patch solves? What are the steps to reproduce? What does the "ar" flag actually do? Thanks!

Cheers
Bryce

Log in or register to post comments

Comment #2

brycefisherfleig CreditAttribution: brycefisherfleig commented 6 June 2014 at 19:25

Status:

Needs review

» Postponed (maintainer needs more info)

Log in or register to post comments

Comment #3

brycefisherfleig CreditAttribution: brycefisherfleig commented 6 June 2014 at 19:25

Component:

General

» Video Transcoding

Log in or register to post comments

Comment #4

RyanPrice CreditAttribution: RyanPrice commented 10 June 2014 at 13:06

Sorry I didn't get alerts to replies on this topic for some reason.

The -ar flag, as explained here: http://libav.org/avconv.html :

‘-ar[:stream_specifier] integer (input/output,audio)’
set audio sampling rate (in Hz)

sets the audio sampling rate. The same flag can be found on the ffmpeg manual: https://ffmpeg.org/ffmpeg.html

For some reason, the module was using -ab instead. Not sure if it was a typo or a deprecated flag, but there is not evidence of the -ab even existing in either manual. I was receiving errors related to the audio frequency it was attempting to encode at and eventually nailed it down to this being the issue.

Hope that explains things.