#97766: Class attribute field option for each dataset in link widget just landed in contrib. And a configurable 'title' and 'rel' have been there for some time. I do not see any duplicate functionality in core's implementation. Should this be something for contrib to add or is there any means to get this added still link? This is essentially a request if this is possible to get into core at this late date.
Class is fairly important on a per instance basis so I can tag a link with different classes and respond to them with jQuery. For example, force popup into an external window vs not setting target=_blank.
If this is agreeable to include, I'll start working on a patch.
Comment | File | Size | Author |
---|---|---|---|
#2 | classperlinkfield-2265519-#1.patch | 25.83 KB | govind.maloo |
#1 | 2265519-options.jpg | 81.63 KB | heddn |
Comments
Comment #1
heddnPicture of how this exists in contrib today:
Comment #2
govind.maloo CreditAttribution: govind.maloo commentedCreated patch for link field
Comment #3
Mac_Weber CreditAttribution: Mac_Weber commentedPostponing feature requests as of the allowed beta changes https://www.drupal.org/contribute/core/beta-changes
Comment #4
mgiffordDrupal 8-beta 1 has been released.
Comment #5
rootworkThe patch in #2 has a bunch of changes that have nothing to do with this issue, and I'm sure would have to be rerolled anyway.
This also might be a duplicate of #2477155: Update LinkWidget to accommodate the attribute., or that issue might be a duplicate of this one, though it also mentions enabling
rel
andtarget
attributes in addition toclass
.Is this eligible for the RC phase? To me this only enables something in the UI, it doesn't change the API or break BC, so it seems like it could.
Comment #6
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commented@rootwork I think the issues are related, but they are not duplicated.
Comment #8
srbracelin CreditAttribution: srbracelin commentedWhere does this currently sit with being completed? It looks like nobody has updated it in awhile.
Comment #9
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedSetting correct status as per comment #5