Hi there, and thanks for a great module.

I've noticed an issue when a field has more than one possible value, the save action seems to fail. No confirmation message appears on the screen. It looks like the values have been saved as they are displayed in the view, but a page refresh shows that the original values are what's actually in the entity and changes weren't saved.

I experienced this with a text area and file field which had more than one possible value - both unlimited or a fixed number of possible values.

It would be amazing if this could work. I have been using this module for a few months mostly with simple text fields and single value fields, but this issue has come up as i have started to make my editable views a bit more complex.

Any thoughts welcome, thanks !

Comments

joachim’s picture

joachim CreditAttribution: joachim commented
Version: 7.x-1.0-beta8 » 7.x-1.x-dev
Status: Needs work » Active

That's weird. I've never tried it with multi-valued fields, but editableviews_handler_field_field_edit::edit_form_submit() just passes the form element to Field API.

Can you try debugging to see what's going wrong?

(BTW: the 'needs work' status has a specific meaning which doesn't apply here. Please review the handbook page about issue queue statuses.)

_paul_meta’s picture

_paul_meta CreditAttribution: _paul_meta commented

Thanks for the reply. I'm not sure how to debug a view .. any suggestions ?

The form submits ok, no error messages, but no confirmation messages from the editable views process either).

Thanks for the tip on the needs work status .. i'm not a regular forum poster and will keep that in mind.

joachim’s picture

joachim CreditAttribution: joachim commented

Start at editableviews_handler_field_field_edit::edit_form_submit(), put in some debug statements with devel module's dsm(). Check what you have there.

If it looks like it's badly formed, or missing, work backwards to what called that method. If it looks ok, work forwards to what it calls with that data.

_paul_meta’s picture

_paul_meta CreditAttribution: _paul_meta commented

I've never used the devel module and am not really clear on this debugging but will give this a shot and report back. Perhaps if someone can check the functionality with multi value fields and see if this is an issue with the module.

Thanks

dealbo’s picture

dealbo CreditAttribution: dealbo commented

Wondering if there has been any progress on this issue because I'm running into it myself.

Editable views works perfectly when I create a view with only two editable fields. When I add a third field, the changes are not saved and there is no message (confirmation or error). I tried adding some debugging messages and get no output at all when I try to save with more than two fields--it seems that the form is not even being submitted.

I'm not very familiar with Devel, but I'm happy to try debugging more with a little direction as to where to look.

Thanks!

joachim’s picture

joachim CreditAttribution: joachim commented

> Editable views works perfectly when I create a view with only two editable fields. When I add a third field,

That's not what this issue is about -- this issue is about problems with a field that is multi-valued.

A problem with adding more than 2 fields would be a separate issue. Though I've made editable views with about a dozen fields in them without any problems, so before you file a new issue I suggest to do a bit more investigating to see if there's anything specific about your fields rather than just how many of them there are.