div classes are being added twice on panel panes [#2263081]

First, thank you for the GREAT module. We love it around here.

We noticed in version 3.4, that classes on panel pane divs started showing up twice. It doesn't show the duplicates under "Inspect element" in Chrome, but when you view the actual page source, it does. And it also shows up as an error on validators. It didn't seem to be an issue in version 3.3.

Here are some examples of what it looks like in code:

<div class="panel-pane pane-views-panes pane-slide-slideshow-panel-pane-1"   class="panel-pane pane-views-panes pane-slide-slideshow-panel-pane-1">

and

<div class="panel-pane pane-node-content"   class="panel-pane pane-node-content">

Is anyone else seeing this? My apologies if this is a duplicate post-- I searched for it and didn't find it.

Thanks.

Comments

Comment #1

strings6 CreditAttribution: strings6 commented 9 May 2014 at 16:02

Issue summary:

View changes

Comment #2

strings6 CreditAttribution: strings6 commented 9 May 2014 at 16:03

Issue summary:

View changes

Comment #3

strings6 CreditAttribution: strings6 commented 14 May 2014 at 17:56

Hello,

Is anyone else experiencing this issue? I'm seeing it on our newest sites in development where drush pulled in Panels 3.4. The biggest problem that it causes is validation errors. Browsers seem to deal with the duplicates just fine, but the validators don't like it.

Thanks

Comment #4

fox mulder CreditAttribution: fox mulder commented 3 December 2014 at 10:47

Same problem here ( Panels version: 7.x-3.4 ):

This solves the problem for me ( template.php ):

function YOURTHEME_preprocess_panels_pane(&$variables){
  if (
    isset($variables['classes_array']) &&
    isset($variables['attributes_array']['class']) &&
    !empty($variables['classes_array']) &&
    !empty($variables['attributes_array']['class'])
  ) {
    $merge = array_unique(array_merge($variables['classes_array'], $variables['attributes_array']['class']));
    $variables['classes_array'] = $merge;
    unset($variables['attributes_array']['class']);
  }
}