Drupal 8

Please help us test the initial version of collapse_text-8.x-1.x: https://www.drupal.org/sandbox/mukila/2760261

Please give us your feedback, comments and report bugs or issues in this ticket.
Thank you.

-----------

Hi,
Are there plans to introduce Drupal8 version of this module?
I would like to help you with development of this version and continue to support module as co-maintainer/maintainer.
Thanks, medion (@InternetDevels team)

CommentFileSizeAuthor
#1 collapse_text-ported_D8-2261881-1.patch49.77 KBgilmord
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gilmord’s picture

Here is patch of D8 version of the module. It provides full module's functionality.

gilmord’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: collapse_text-ported_D8-2261881-1.patch, failed testing.

DYdave’s picture

Status: Needs work » Postponed

Hi guys,

Thank you very much for your interest for the Collapse Text module, posting this Feature request, coming up with patches/code and I certainly apologize for the delay of this reply.

I could surely understand you are probably very excited about the upcoming release of Drupal 8, as we all are, but in fact module's currently supported branches (mostly 7.x) could most likely benefit greatly from your help and efforts.

Indeed, we could maybe keep on working on existing issues before adding more branches/work and at least wait for a Beta version of Drupal 8 to be released before rushing into porting a code base which we know already has several reported flaws.

Additionally, answering tickets in Collapse Text's issue tracker could help highlighting your overall understanding of module's code and your aptitude to handle support requests, which would in return build up your experience if you ever wanted to be considered as a potential maintainer of the module (@id.medion, hope I didn't misunderstand your request).

As much as I would greatly like to start working on the port to collapse_text-8.x (believe me, it's already hard to contain my jumpy self), I believe this issue should be marked as Postponed for now, work should stay focused on collapse_text-7.x, and there's plenty to do:

  • Improving Simple Tests
  • Documentation
  • Aligning module with coding standards/PAReview
  • Fixing bugs
  • and so much more....

 
Once again your help is so much appreciated, but I hope we could just hold off our horses for a few more months, while we try tackling as many more existing issues as possible to port a much cleaner version.

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on this comment or this ticket in general, I would be glad to provide more information or explain in more details.

Many thanks to everyone for your great help, reviews, testing/reporting, patches, feedback and comments on this issue.
To be continued .... Cheers!

mukila’s picture

Hi DYdave,

I would like to co-maintain the Collapse Text module. I already port the Drupal 8 version of this module(https://www.drupal.org/sandbox/mukila/2760261). kindly add me as a maintainer so that I can commit my works and we can combine and work on the further tweaks.

DYdave’s picture

Title: Drupal 8 port of Collapse Text » Port Collapse Text to Drupal 8
Issue summary: View changes
Status: Postponed » Needs review

Hi @mukila,

Thanks very much for following up on this issue and kindly proposing your help to maintain the module.

Thanks very much also for contributing to port the Collapse Text module to Drupal 8.

Since I guess this code is going to feel pretty new to most users (at least it is to me), I would recommend using this ticket and your sandbox to work first on the testing of Drupal 8 module's code. It would be great if we could have some feedback from several users, on the testing in different situations, to see if any particular issues are encountered.

Additionally, I will need a little bit of time myself to test and review your sandbox's code.

Once the code has been tested, reviewed and confirmed to work at least for "simple"/"normal" cases, I don't think there would be any problem to have your sandbox merged with Collapse Text's repository.

I have modified issue's title and summary, hopefully it will attract users' attention.

Feel free to let us know at any time if you would have any questions, objections, concerns, or issues on this ticket or the module in general, we would surely be glad to provide more information or explain in more details.

Many thanks in advance to everyone for your reviews, testing, reporting and participation in this module's issue tracker.
Cheers!

Carlos Miranda Levy’s picture

I've been testing/using Mukila's port on Drupal 8 production sites for 6 months now without any problem. It even works fine with the ckeditor_tabber module. This is such a useful and nice module that so many users can benefit from. I propose Mukila's port is included as a formal 8.x branch for the module.

mukila’s picture

@Carlos Miranda Levy
Thanks for testing and posting your comments here
@DYdave
Hope you also tested the drupal 8 version of the module. We also got the some positive feedback about the module. So it's the right time to port it to Drupal 8. Please add me as a maintainer so I can commit the code.

DYdave’s picture

Hi @mukila,

Thank you very much for your contributions and reaching out.
I apologize for the delay of my reply but I have been kept rather busy lately.

Just a quick message to request a little bit more time. Hopefully, I should be able to review your module, and get it tested in the next two to three weeks. By then I'm hoping I'll be able to potentially merge your project tree with collapse_text's new D8 dev branch.

I acknowledge the reception of your request, code and the positive comments from other users.
I would like to help getting this moving forward, but would need a little bit of time to go over it.

I hope I was able to answer your questions.
Thanks again very much for your great involvement in the Drupal community.
Cheers!

mukila’s picture

Closing this issue as Drupal 8 version of the collapse text module is released already.

mukila’s picture

Status: Needs review » Closed (outdated)