Problem/Motivation

I have a field handler that adds subfields to certain migration classes. These subfields are not shown on the migration edit form, but they are shown on the migration view page. This is because the migration variable is not being passed to the fields method in the edit form.

Migration view page

Line 852: $destination_fields = $destination->fields($migration);

Migration edit form

Line 971: $dest_fields = $migration->getDestination()->fields();

Proposed resolution

The migration variable should be passed to the fields method in the edit form.

Remaining tasks

  1. Patch is ready for review.
CommentFileSizeAuthor
#1 edit-destination-fields-2261227.patch959 bytesDarren Oh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Darren Oh’s picture

Title: Destination fields on migration edit page don’t match view page » Missing subfields on edit mapping form
Assigned: Darren Oh » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
959 bytes

Patch attached.

  • mikeryan committed 2fb7873 on 7.x-2.x authored by Darren Oh
    Issue #2261227 by Darren Oh: Fixed missing subfields on edit
    mapping...
mikeryan’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mikeryan’s picture

Issue tags: +Migrate 2.6