Update theme_item_list processing [#2260659]

Move all logic from theme_item_list() to bootstrap_preprocess_item_list(). Override item-list.html.twig to remove useless div.item-list wrapper.

Comment	File	Size	Author
#1	bootstrap-item-list-2260659-1.patch	6.03 KB	m1r1k
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

m1r1k CreditAttribution: m1r1k commented 7 May 2014 at 12:19

Status:

Active

» Needs review

File	Size
bootstrap-item-list-2260659-1.patch	6.03 KB

Comment #2

m1r1k CreditAttribution: m1r1k commented 7 May 2014 at 12:27

Parent issue:

» #2252061: [meta] Templates and preprocess functions clean up

Comment #3

markhalliwell

English

CreditAttribution: markhalliwell commented 7 May 2014 at 15:43

Assigned:	m1r1k	» Unassigned
Priority:	Major	» Normal
Status:	Needs review	» Needs work

+++ b/theme/system/item-list.html.twig
@@ -0,0 +1,39 @@
+ * @see template_preprocess_item_list()
+ * @see bootstrap_preprocess_item_list()

Move above core's implementation.

+++ b/theme/system/item-list.html.twig
@@ -0,0 +1,39 @@
+    {%- if title -%}
+      {{ title }}
+    {%- endif -%}

+++ b/theme/system/item-list.vars.php
@@ -0,0 +1,40 @@
+    // @todo implement #type => html_tag here
+    // Set defaults.
+    $title += array(
+      'level' => 'h3',
+      'attributes' => array(),
+    );
+    // Heading outputs only when it has text.
+    if (!empty($title['text'])) {
+      $variables['title'] = '<' . $title['level'] . new Attribute($title['attributes']) . '>';
+      $variables['title'] .= empty($title['html']) ? String::checkPlain($title['text']) : $title['text'];
+      $variables['title'] .= '</' . $title['level'] . '>';
+    }

I agree, this should be html_tag instead here and just make the title a renderable array. Twig will automatically render it when it's printed.