it would help the code in Schrodicache a great deal if the created time for items had a better granularity than a second.

replacing time() with microtime(TRUE) greatly increases the hit rate from APC when using Schrodicache. simple patch against 7.x-1.x attached.

CommentFileSizeAuthor
#2 2259103-2.patch434 bytesAnonymous (not verified)
microtime-created.patch424 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

msonnabaum’s picture

msonnabaum CreditAttribution: msonnabaum commented

I agree with the general idea, but I would prefer to see it rounded a bit. Surely we don't need the full precision here.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
2259103-2.patch434 bytes

seems reasonable, new patch does that.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Fixed

Committed/pushed to 7.x-1.x, thanks!

  • Commit bb8d0b0 on 7.x-1.x by catch: 
    Issue #2259103 by beejeebus: Set cache->created with microtime(), not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented
Related issues: +#2335727: Setting $cache->created with msec precision borks page caching.
Jeremy’s picture

Jeremy CreditAttribution: Jeremy commented

We had to undo this change as it cased a regression. For solutions like Schrodicache preferring higher precision, use $cache->created_microtime if existing instead of $cache->created.
http://cgit.drupalcode.org/memcache/commit/?id=a6a1ca8