8.x-1.x-dev doesn't work in HEAD any more.

CommentFileSizeAuthor
#12 d8_codefilter.interdiff.txt1.82 KBfago
#12 d8_codefilter.patch23.1 KBfago
#11 2258339-chasing-head-11.patch23.12 KBeporama
#11 interdiff-2258339-10-11.txt4.36 KBeporama
#10 chasing_drupal_8_head-2258339-10.patch19.26 KBnaxoc
#8 interdiff.txt2.03 KBnaxoc
#8 chasing_drupal_8_head-2258339-8.patch8.06 KBnaxoc
#3 codefilter-2258339-psr4.patch15.08 KBSteven Jones
#1 chasing-d8-2258339-1.patch1.02 KBeporama
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eporama’s picture

eporama CreditAttribution: eporama commented
Status: Active » Needs work
FileSize
chasing-d8-2258339-1.patch1.02 KB

Here's an initial patch which allows the module to be activated and applied to admin/config/content/formats/manage/restricted_html for example.

However, the code is not actually activated on the node.

Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented

Well, being able to enable the module is a good start. Thanks for your help! I've pushed this patch with attribution.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
FileSize
codefilter-2258339-psr4.patch15.08 KB

Since core went to PSR-4 and moved to 'src' the module is brokened.
But here's a patch!

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Status: Needs work » Needs review
Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented

Let's just get a review.

The last submitted patch, 1: chasing-d8-2258339-1.patch, failed testing.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Status: Needs review » Needs work

Patch applied and tested cleanly, despite what cheeky System Message says.

naxoc’s picture

naxoc CreditAttribution: naxoc commented
Status: Needs work » Needs review
FileSize
chasing_drupal_8_head-2258339-8.patch8.06 KB
interdiff.txt2.03 KB

Here is a little more keeping up with head.

I rerolled and did some small changes to stuff that has changed in D8.

Status: Needs review » Needs work

The last submitted patch, 8: chasing_drupal_8_head-2258339-8.patch, failed testing.

naxoc’s picture

naxoc CreditAttribution: naxoc commented
Status: Needs work » Needs review
FileSize
chasing_drupal_8_head-2258339-10.patch19.26 KB

Fair enough testbot. The tests could not be found because they were in the wrong place. Here is another patch.

eporama’s picture

eporama CreditAttribution: eporama commented
FileSize
interdiff-2258339-10-11.txt4.36 KB
2258339-chasing-head-11.patch23.12 KB

The previous patch seems to have actually just removed the tests instead of putting them in the right place. I have put the test file back in src/Tests

Here's a patch that puts the tests files back and also moves the css and js from codefilter.module into codefilter.libraries.yml as I was getting errors about #attachments not allowing css.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago at drunomics commented
Title: Chasing Drupal 8 head » Drupal 8 version is outdated
Priority: Normal » Critical
FileSize
d8_codefilter.patch23.1 KB
d8_codefilter.interdiff.txt1.82 KB

Thanks, #11 works almost fine. Only issue I ran into is that meanwhile the String class got replaced. Updated it respectively.

Imo, this should be committed to Git asap as the code there is rather outdated.

  • cam8001 committed 41e4b71 on 8.x-1.x authored by fago 
    Issue #2258339 by eporama, naxoc, fago, Steven Jones: Chasing Drupal 8...
Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Status: Needs review » Fixed

Thanks guys, commited to 8.x-1.x!

http://cgit.drupalcode.org/codefilter/commit/?id=41e4b71

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.