#1939008: Convert theme_table() to Twig added a new assertTextPattern() method, but added it to one particular test class (core/modules/node/lib/Drupal/node/Tests/NodeTypeRenameConfigImportTest.php) versus a test base class, despite the fact that WebTestBase::assertPattern() does almost (but not quite) the same thing. It seems like a more general helper method, though it's a little hard to tell because the docs don't explain how/where you'd use it.
I still think assertTextPattern() is needs a) some clarification as to its purpose a) to be moved to a test base class, and/or c) the changes made "upstream" in the WebTestBase method.
TODO: Discuss/Fix those things. :)
Comments
Comment #1
sunThe method will be moved into the new AssertContentTrait. I'm generally not touching the moved code of methods though, so this is just to point out that the code will be located somewhere else very soon.
Comment #2
sunComment #3
mgifford@sun - has that move happened?
Comment #7
Mile23AssertContentTrait::assertTextPattern() does exist and is used by all of the various test bases that have content to assert against.