Updated: Comment #1

Problem/Motivation

The library used in the drush makefile does not contain the library in the root folder, and so it does not work out of the box.

Proposed resolution

Either use a different library that includes the actual library files in the root, or extract just the folder containing the library files.

Remaining tasks

  • Decide on best path forward
  • Write patch
  • Review patch
  • Commit patch
CommentFileSizeAuthor
#8 library_used_in_the-2257461-8.patch.diff406 bytesvermario
#5 openlayers-7.x-2.0-beta9_makefile_release_patch-2257461-5.patch518 bytesJan van Diepen
#1 openlayers-drush-make-2257461-1.patch506 bytesjantoine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jantoine’s picture

jantoine CreditAttribution: jantoine commented
Issue summary: View changes
Status: Active » Needs review
FileSize
openlayers-drush-make-2257461-1.patch506 bytes

Here's a patch that uses a library download link from the openlayers.org website. Not saying this is the best path, but it works for me.

  • Pol committed 66ca5d6 on 7.x-2.x authored by jantoine 
    Issue #2257461 by BWPanda: Library used in the drush makefile doesn't...
Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented
Status: Needs review » Fixed

Thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Jan van Diepen’s picture

Jan van Diepen CreditAttribution: Jan van Diepen commented
Version: 7.x-2.x-dev » 7.x-2.0-beta9
FileSize
openlayers-7.x-2.0-beta9_makefile_release_patch-2257461-5.patch518 bytes

The library on openlayers.org is not available at the moment.
We are using openlayers-7.x-2.0-beta9 which uses openlayers library v2.13.1.
Going to post a patch to load release-2.13.1.zip from github since v2.13.1.zip is not available.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented

Fixed in 7.x-2.x... Thanks !

ShaneOnABike’s picture

ShaneOnABike CreditAttribution: ShaneOnABike commented

Great! Can we not make another official release since this is actually blocking kplatforms and Aegir distributions from properly working with openlayers.

vermario’s picture

vermario CreditAttribution: vermario commented
FileSize
library_used_in_the-2257461-8.patch.diff406 bytes

Adding a different type of patch here, one that removes the downloading of the library altogether from the makefile. This is very specific for our usecase, where we cannot at the moment update the module, but we need the makefile to build correctly. So, a very limited use case, and fixed in newer version of the module.