Translate from a translation instead of the source language

provided tests

Tests looks ok so far, a few remarks:

- We should submit and load the job/item to verify that the items were added correctly and the correct data has been pulled
- Because I'm pretty sure that the node_source and possibly other sources as well will not support this correctly in their getData() implementation, tmgmt_node for example simply loads the node it has, but it will need to look if it's the right language and if not, load the corresponding translation instead. locale and i18n are likely similar, tmgmt_entity might work because it loads the values based on the source language from the single entity.
- Which means that we do not only need to test the UI, we should also add API tests for the other sources by saving a source + translation, create a job with source language of that translation and then request data for it. Should not be very complicated, but we should cover all sources, even the one I suspect works (tmgmt_entity)

extended the tests

Yeah, it looks like I got too much used to php 5.4...

Here's initial patch with translation loading for i18n and node sources. It also contains basic UI to enforce source language at the cart. Basic workflow should work, needs handling of special cases + test coverage for them.

1. +++ b/sources/i18n_string/tmgmt_i18n_string.plugin.inc
   @@ -18,12 +18,24 @@ class TMGMTI18nStringSourcePluginController extends TMGMTDefaultSourcePluginCont
   -          '#translate' => TRUE
   -        );
   +        // If the job source language is not "en" try to load an existing
   +        // translation for the language and use it as the source.
   +        if ($source_language != 'en' && $translation = $string->get_translation($source_language)) {
   

   This is not correct, the i18n source language is the site default language or the configurable override, see elsewhere in that file.

2. +++ b/sources/node/tmgmt_node.plugin.inc
   @@ -15,6 +15,17 @@ class TMGMTNodeSourcePluginController extends TMGMTDefaultSourcePluginController
   +        if ($translation->language == $job_item->getJob()->source_language) {
   +          $node = node_load($translation->nid);
   +        }
   

   You should do a break then to make it clear that we're done processing the array.

   The translations should be keyed by language, so you could get the array and then access it directly.

   Not sure if we want to care about non-existing translations, possibly throw an exception but then we should do it everywhere...

3. +++ b/ui/includes/tmgmt_ui.pages.inc
   @@ -886,6 +886,24 @@ function tmgmt_ui_cart_content($form, &$form_state) {
   +    '#description' => t('The source language is determined from the source items\' language. If you wish to enforce a different language you can select one after ticking this checkbox.')
   

   source item's language => item's source language.

   Possibly extend this with a sentence that says if one is selected then it will take the translation of the source item in that language and ignore it if it is not present.

4. What we do elsewhere to load the job we're looking at is parsing the URL, you can find the snippet for that elsewhere in that test.

The patch is not yet complete, but ready for review.

Implemented:
- the exception in case there is no translation. This exception is then used also by UI to display a message to the user.
- comments above except the message

Missing:
- throwing an exception in the entity source. Here not sure how to determine if it is translated or not as it the fallback there to the original content is by default
- tests for the exceptions.

completed. Let's see if testbot agrees.

The problem with forced language and items that do not apply is that we just receive an exception that something went wrong, not really knowing what - that is the reason for the error message. What would help here is to introduce something like $job_item->hasSource($language). This would also solve the problem that we learn about missing source for the given language after an item is added to a job, from which it is possible to retrieve the source language.

please see the patch.

eh..

Committed with the attached changes.

Spent way too much time discussing the UI messages and descriptions with Miro. It still isn't perfect but we both think it's much better. The warning after creating the job has been removed as there was nothing useful in there, instead, we made the descriptions on cart form explain the quality problem (saying that on the job checkout page doesn't help at the time... you already created the job and it's not yet time to review it).

Actually...

First part of the patch/port. Needs to be worked on.

1. +++ b/sources/locale/src/Plugin/tmgmt/Source/LocaleSource.php
   @@ -179,33 +179,36 @@ class LocaleSource extends SourcePluginBase {
   +      throw new TMGMTException(t('Unable to load %language translation for the locale %id',
   +        array('%language' => $job_item->getJob()->getSourceLanguage()->getName(), '%id' => $job_item->id())));
   +    }
   

   the exception message actually said locale id, not job item id, so lets return that (getItemId() I think)

2. +++ b/sources/locale/src/Tests/LocaleSourceTest.php
   @@ -2,6 +2,7 @@
    /**
     * @file Contains \Drupal\tmgmt_locale\Tests\LocaleSourceTest.php.
   + * @file Contains \Drupal\tmgmt_locale\Plugin\tmgmt\Source\LocaleSource.
     */
    
   

   That's.. weird ;)

   Both the new and existing @file definition are wrong, and there shouldn't be two. Compare with other files how it should look like.

3. +++ b/sources/locale/src/Tests/LocaleSourceTest.php
   @@ -104,6 +105,45 @@ class LocaleSourceTest extends TMGMTKernelTestBase {
      /**
   +  +   * Test if the source is able to pull content in requested language.
   +  +   */
   +  function testRequestDataForSpecificLanguage() {
   +      $this->addLanguage('cs');
   +
   +      $locale_object = db_query('SELECT * FROM {locales_source} WHERE source = :source LIMIT 1', array(':source' => 'Hello World'))->fetchObject();
   +
   +      $plugin = $this->container->get('plugin.manager.tmgmt.source')->createInstance('locale');
   +      $reflection_plugin = new \ReflectionClass('\Drupal\tmgmt_locale\Plugin\tmgmt\Source\LocaleSource');
   +      $updateTranslation = $reflection_plugin->getMethod('updateTranslation');
   +      $updateTranslation->setAccessible(TRUE);
   

   Strange indendation on comments, and 4 instead of 2 in the code.

Added the second part of the patch, and fixed the issues commented above.

+++ b/src/Tests/TMGMTUiTest.php
@@ -586,4 +588,71 @@ class TMGMTUiTest extends TMGMTTestBase {
+  /**
+   * Test if the source is able to pull content in requested language.
+   */
+  function testCartEnforceSourceLanguage() {

As discussed, let's move this to a new TmgmtCartTest.

Looks good otherwise!

Moved the function to the new file.

Deleted too much...

Fixed the test.

Great, committed.