Rule action for synching user and contact, or creating a new contact [#2256515]

Patch attached with rules action "crm_core_user_sync_contact":
* takes a user argument (required) and contact (optional)
* creates a new CRM Contact if it was not supplied
* creates the relation object to sync the two

It's working ok for me on a few dev sites, but haven't tested yet in production.

Comment	File	Size	Author
#4	crm_core_user_sync-sync_or_create_contact-2256515-3.patch	2.91 KB	AaronBauman
#3	crm_core_profile_commerce_items-cc_fail_reload-2179187-3.patch	2.91 KB	AaronBauman
#1	crm_core_user_sync-sync_or_create_contact-2256515.patch	2.49 KB	AaronBauman

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

AaronBauman

he/him

CreditAttribution: AaronBauman commented 1 May 2014 at 20:19

File	Size
crm_core_user_sync-sync_or_create_contact-2256515.patch	2.49 KB

Comment #2

RoSk0

he/him

Russian

Wellington

CreditAttribution: RoSk0 commented 21 July 2014 at 12:37

Status:

Needs review

» Needs work

+++ crm_core/modules/crm_core_user_sync/crm_core_user_sync.rules.inc	(revision 122)
@@ -0,0 +1,74 @@
+ * Implements hook_rules_action_info()

Need a dot at the end.

+++ crm_core/modules/crm_core_user_sync/crm_core_user_sync.rules.inc	(revision 122)
@@ -0,0 +1,74 @@
+    // If contact already exists for this account, ignore whatever input is given.

If contact already exists we should load relation and return both.

+++ crm_core/modules/crm_core_user_sync/crm_core_user_sync.rules.inc	(revision 122)
@@ -0,0 +1,74 @@
+  $contact->uid = $account->uid;

We should save contact after this.

Patch needs to be restructured and created following Drupal coding standards.

Comment #3

AaronBauman

he/him

CreditAttribution: AaronBauman commented 23 February 2016 at 16:55

Status:

Needs work

» Needs review

File	Size
crm_core_profile_commerce_items-cc_fail_reload-2179187-3.patch	2.91 KB

1 file was hidden/shown/deleted

File	Size
crm_core_user_sync-sync_or_create_contact-2256515.patch	2.49 KB

Patch re-rolled with one change.

+++ crm_core/modules/crm_core_user_sync/crm_core_user_sync.rules.inc	(revision 122)
@@ -0,0 +1,74 @@
+ * Implements hook_rules_action_info()

Need a dot at the end.

Dot added

+++ crm_core/modules/crm_core_user_sync/crm_core_user_sync.rules.inc	(revision 122)
@@ -0,0 +1,74 @@
+    // If contact already exists for this account, ignore whatever input is given.

If contact already exists we should load relation and return both.

Yes, I guess we need to deal with an existing contact ... somehow.
If a contact is given as an argument to this action, we cannot just ignore it.
There's no "merge entity" mechanism that I know about - any ideas?

+++ crm_core/modules/crm_core_user_sync/crm_core_user_sync.rules.inc	(revision 122)
@@ -0,0 +1,74 @@
+  $contact->uid = $account->uid;

We should save contact after this.

I disagree here. In general when rules returns a new or existing entity, it's up to the rule builder to add the "entity_save" action. If the rule builder has more work to do on the new entity, it's much more efficient to wait until the work is done before saving. This is how node and user actions work, as well as other entity types, so that's how I've modeled this action.