Problem/Motivation

Speed up testbot and simplify tests by using the testing profile instead of the standard profile.

Steps to reproduce

Proposed resolution

Convert Drupal\node\Tests\NodeAccessBaseTableTest to use the testing profile, not the standard profile.

Remaining tasks

Update patch
Review
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#23 2254199-nr-bot.txt144 bytesneeds-review-queue-bot
#21 2254199-21.patch2.01 KBsmustgrave
#21 interdiff-19.21.txt1.76 KBsmustgrave
#19 2254199-19.patch650 bytessmustgrave
#19 interdiff-17-19.txt562 bytessmustgrave
#17 2254199-17.patch669 bytessmustgrave
#11 2254199-11.patch746 bytesvacho
#2 testperf.system-BreadcrumbTest.patch1.51 KBsun
testperf.system-BreadcrumbTest.patch1.5 KBsun

Issue fork drupal-2254199

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, testperf.system-BreadcrumbTest.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
testperf.system-BreadcrumbTest.patch1.51 KB

menu was renamed into menu_ui

Status: Needs review » Needs work

The last submitted patch, 2: testperf.system-BreadcrumbTest.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Issue tags: +Needs reroll
vacho’s picture

vacho CreditAttribution: vacho at Skilld commented
Issue tags: -Needs reroll
FileSize
2254199-11.patch746 bytes

Patch updated, rerolled.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Version: 9.3.x-dev » 10.0.x-dev
Issue summary: View changes
Parent issue: #1595028: Convert tests using Standard profile to use Testing profile instead » #3270566: [meta] Convert remaining tests using Standard profile to use Testing profile instead
Related issues: +#1595028: Convert tests using Standard profile to use Testing profile instead

Adding issue summary and re-parenting.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review
FileSize
2254199-17.patch669 bytes

didn't upload an interdiff because I don't know the original issue the previous patches were solving. But updated the install profile.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review
FileSize
interdiff-17-19.txt562 bytes
2254199-19.patch650 bytes

Fixed CI issue.

Status: Needs review » Needs work

The last submitted patch, 19: 2254199-19.patch, failed testing. View results

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review
FileSize
interdiff-19.21.txt1.76 KB
2254199-21.patch2.01 KB

Attempting to fix test case.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented 
+  protected static $modules = [
+    'menu_test',
+    'block',
+    'olivero_test',
+    'filter_test',
+    'field_ui',
+    'menu_link_content',
+    'menu_ui',
+    'filter',
+    'dblog',
+  ];

So reason I'm adding all these modules is because the test is check a variety of different paths that these modules install. Olivero_test ships with an article, comment field, teaser, etc which is tested also.

+  protected $defaultTheme = 'olivero';

Using olivero because standard installs it and the setup() was setting an olivero block

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2254199-nr-bot.txt144 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented

Actually wondering if this should be changed. It needs a number of modules, content type, vocabulary, etc so essentially it's a standard install no?

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Version: 10.0.x-dev » 11.x-dev

It is still better to test without relying on the standard profile. That profile installs 32 modules whereas this test is now using 9 modules, that is a significant reduction.

Also, it helps in the module list is sorted and needs to convert to an MR.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Assigned: Unassigned » smustgrave

smustgrave opened merge request !5565

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review

Converted to an MR.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs review » Needs work
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review

Addressed feedback.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Assigned: smustgrave » Unassigned
marvil07’s picture

marvil07 CreditAttribution: marvil07 at Adapt commented
Status: Needs review » Reviewed & tested by the community

@smustgrave, changes look quite lean 👍.

After @quietone's suggestion on the last review round, I think the set of used modules in the test is the minimal set.

Locally, even if different and likely slower than gitlab runners, I see an improvement jump in test time for that test from 01:04.356 to 00:55.312.

Marking as RTBC.

  • catch committed 860ab2c3 on 10.2.x 
    Issue #2254199 by smustgrave, sun, vacho, quietone, marvil07: Fix test...

  • catch committed 1fcbbff8 on 11.x 
    Issue #2254199 by smustgrave, sun, vacho, quietone, marvil07: Fix test...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.