This is a standard Calendar page:
http://eagleridgeacademy.org/events
There's a problem with the on the May and June pages:
http://eagleridgeacademy.org/events/month/2014-05
http://eagleridgeacademy.org/events/month/2014-06
First of all, the max items per day is currently set at 3.
On May 20th, there is the middle of one multi-day event and two other events shown. But if you click on the May 20th date, you will see that there is actually 3 non-multi-day events, one more than is shown on the month page. In this case, it seems the "More" link should be on the month page, but it is not there.
Again, on June 6th, it is the end of a multi-day event and there is one all-day event and three other events on the day. All the events except the last one are shown and no "More" link is shown as well on the month page, while the day page shows all items.
There's something about these days that are right on the edge of what qualifies for a "More" link and has a multi-day event included that seems to throw the "More" link display logic in the month display off. I'm currently trying to step through the code and find the problem and the solution, so if I find it I will certainly update this post.
Note: I am going to update the live code with the fix below so that the "More" link does appear when I think it should. But if you want to recreate similar sets of events on a test as on those days, it should be a good place to start for reproducing these issues.
Comment | File | Size | Author |
---|---|---|---|
#3 | calendar-more-link-month-not-showing-2253065-3.patch | 1.41 KB | nmillin |
Comments
Comment #1
dandaman CreditAttribution: dandaman commentedSince the display of the day's events does loop through every item, I added a variable that gets set when it reaches one of these events that will not be displayed. I can't completely grok how the
$cur_cnt
and$total_cnt
are not working perfectly in some cases, so this finds exactly when something will not be displayed and adds a "more" link then. I don't have the time to roll it as a patch against the dev right now, but I'll try to come back to it later this week if I have time.Comment #2
dandaman CreditAttribution: dandaman commentedUpdated issue summary to note that the example has now been updated with the fix above.
Comment #3
nmillin CreditAttribution: nmillin commentedI ran into this issue and the code above solved my issue. Uploading patch of the fix that dandaman provided.
Comment #4
dandaman CreditAttribution: dandaman commentedApplied the code to 7.x-3.5 again and it fixed the issue on the same site again. Thanks for testing it as well and rolling the patch nmillin!
Comment #5
erwangel CreditAttribution: erwangel commentedHad the same problem, This (#3) applied to 7.x-3.5 worked for me also. Thank you both nmillin & dandaman!
Comment #6
lucuhb CreditAttribution: lucuhb commentedThe patch #3 fixes the problem for me too. Thanks for this !
Comment #8
Neslee Canil PintoCommitted, Thanks.