backups can be a very time-consuming operation in aegir.

disable is designed to quickly disable a site without deleting the data. in essence, it just changes the virtual host configuration right now, but also changes the alias and does a backup.

this makes the disable task much less useful because the site can take a while to disable.

let's stop backing up sites on disable.

Comments

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Status: Active » Needs review

patch is obviously trivial:

diff --git a/platform/disable.provision.inc b/platform/disable.provision.inc
index 7a04bce..84513a4 100644
--- a/platform/disable.provision.inc
+++ b/platform/disable.provision.inc
@@ -11,9 +11,6 @@
  */
 function drush_provision_drupal_pre_provision_disable($backup_file = null) {
   if (d()->type == 'site') {
-    drush_set_option('force', true, 'process');
-    drush_invoke('provision-backup', $backup_file);
-    drush_unset_option('force', 'process');
     d()->site_enabled = false;
   }
 }

we would need to document that as an API change in the 3.0 branch, and i wonder if we shouldn't backport this to 2.x...?

  • Commit f5b7d2e on 7.x-3.x by anarcat: 
    do not backup sites on disable, closes: #2252941
anarcat’s picture

anarcat CreditAttribution: anarcat commented
Status: Needs review » Patch (to be ported)

i applied the patch to 3.x, and it also applies cleanly to 2.x. I am putting this as "to be ported" to get feedback from other maintainers.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented

I agree. Presumably we still backup before deletion, so there shouldn't be any danger here.

helmo’s picture

helmo CreditAttribution: helmo commented

ack, as we don't lose any data I see no real reason to make a backup.

  • Commit f5b7d2e on 7.x-3.x, dev-helmo-3.x by anarcat: 
    do not backup sites on disable, closes: #2252941

  • anarcat committed f5b7d2e on 
    do not backup sites on disable, closes: #2252941

  • anarcat committed f5b7d2e on 2358795-provision-save-on-verify 
    do not backup sites on disable, closes: #2252941
ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Version: 7.x-3.x-dev » 6.x-2.x-dev

  • anarcat committed f5b7d2e on 7.x-4.x 
    do not backup sites on disable, closes: #2252941
helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented
Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Patch (to be ported) » Fixed

The 6.x-2.x branch will go EOL along with Drupal this week. So I'm closing
this issue. If it remains a confirmed issue in 7.x-3.x, feel free to re-open,
or better yet, create a new issue referencing this one.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.