Problem/Motivation

@amateescu was suggested Index summary page improvements.

Proposed resolution

Improve styling. Basically, get rid of all non-necessary classes and styles and use just default table styles from Drupal core with minimal improvements.

#2252713: Table headers inside of status reports look strange.
#2254785: Progress bar 0% or over 100% visual BUG

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dragan Eror’s picture

Issue summary: View changes
Dragan Eror’s picture

Issue summary: View changes
Dragan Eror’s picture

Assigned: Unassigned » Dragan Eror
Dragan Eror’s picture

Issue summary: View changes
Dragan Eror’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
161.31 KB
1.68 KB

Here are some improvements of index summary page...

Dragan Eror’s picture

Added new line at the end of file.

s_leu’s picture

  1. +++ b/css/search_api.admin.css
    @@ -49,3 +49,14 @@
    + * Index page.
    

    I would call it "Styles for index status page."

  2. +++ b/src/Form/IndexStatusForm.php
    @@ -29,6 +29,10 @@ class IndexStatusForm extends FormBase {
    +    // Attach the admin css
    

    Fullstop at the end of sentence is missing.

Rest looks good to me.

Dragan Eror’s picture

Here are patch improvements...

s_leu’s picture

Status: Needs review » Reviewed & tested by the community

Ok fine.

Dragan Eror’s picture

Removed animation from progress bar.

Berdir’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

  • Commit d4a8a78 on master authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    
aspilicious’s picture

Can we add some left margin or padding on the first column?
The word "status" is glued against the border of the box.

aspilicious’s picture

And another thing, why didn't we make the background color of the first column match the screenshot in the summary?

Berdir’s picture

@aspilicious: That's fixed by the referenced core issue.

Dragan Eror’s picture

Issue summary: View changes
Status: Fixed » Needs work

@aspilicious in the mean time the opinion was changed. The first requirement was changed from make it look like status page to just make it use core styles for table (fixed in description), with minimal improvement.

Just now there is no CSS styles applied on that table.

OK, discussed with @Berdir, I'll improve that table a bit for our purposes.

Dragan Eror’s picture

Status: Needs work » Needs review
FileSize
287 bytes

Improved table, added padding on the left side for first column. The background will not be changed here in this issue unless is explicitly required.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
Dragan Eror’s picture

Title: Improve UI for index summary page » Improve UI for server/index summary pages
Status: Reviewed & tested by the community » Needs review
FileSize
490 bytes

Updated issue name to fit also server summary page.
Also table styles for server summary page are applied.

  • Commit d4a8a78 on master, views authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    
LewisNyman’s picture

+++ b/css/search_api.admin.css
@@ -49,3 +49,17 @@
+/* Remove animation */
+.search-api-index-status .progress__bar {
+  background-image: none;
+}

Why are we removing the animation from the progress bar on this page? The behaviour of the progress bar should be consistent on every page.

Dragan Eror’s picture

That was requirement by @Berdir, @amateescu and @drunken_monkey :)
Basically we agreed it looks so strange because you never see when it moves. Or maybe we should introduce "static" progress bar also in core?
And btw, the animation is "moving" in wrong direction, to left, it should go to right like it is natural.

drunken monkey’s picture

Why are we removing the animation from the progress bar on this page? The behaviour of the progress bar should be consistent on every page.

Since there is no progress currently happening, I don't think the normal progress bar is adequate here. I'm no UI expert, but it just looks very strange. Having a quick overview of the current progress is still useful, though, which is why I think the bar should stay, just unanimated (like it is currently in D7).

  • Commit d4a8a78 on master, views, htmlfilter, 2235381-fix-config-schemas authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, 2235381-fix-config-schemas, move-integration-tests-subfolder authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, 2235381-fix-config-schemas, move-integration-tests-subfolder, 2230881-test-all-processors authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, 2235381-fix-config-schemas, move-integration-tests-subfolder, issue-2273743 authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, 2235381-fix-config-schemas, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    
LewisNyman’s picture

Since there is no progress currently happening, I don't think the normal progress bar is adequate here. I'm no UI expert, but it just looks very strange. Having a quick overview of the current progress is still useful, though, which is why I think the bar should stay, just unanimated (like it is currently in D7).

Sure, but changing how the progress bar behaves depending on which module uses it introduces inconsistency for people using these modules. This is a really bad idea. If you have opinions about the current progress bar, that's great, let's talk about that in a core issue. It's possible that we've just identified a situation that we hadn't considered previously or maybe a progress bar is not suitable for the information you're communicating.

Dragan Eror’s picture

If you have opinions about the current progress bar, that's great, let's talk about that in a core issue. It's possible that we've just identified a situation that we hadn't considered previously

I agree, let's talk... We discovered 2 things here that don't have too much sense:

  1. The progress bar is animated but there is no progress on the page, it's just static info.
  2. The animations of progress bar is going to wrong direction.

Suggesting to introduce 'static' progress bar state without animation.
And suggesting to switch animation direction for animated one.

@LewisNyman will you be willing to open new issue in core please?

LewisNyman’s picture

I have create #2277551: Add a 'static' variant to the progress bar. I'm not going to create an issue to change the animation direction because we've already justified the current direction and it would imply that I agree. Feel free to create it so we can discuss.

x3cion’s picture

Hi,

I've created a patch for #2277551: Add a 'static' variant to the progress bar and if it is accepted - or whatever has to be done for it to get implemented - you'd need the patch attached here.

  • Commit d4a8a78 on master, views, htmlfilter, 2235381-fix-config-schemas, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, 2235381-fix-config-schemas, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2 authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2, 2257113-Index-Processors-Fields authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2, 2257113-Index-Processors-Fields authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2, 2257113-Index-Processors-Fields, config-schema authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2, 2257113-Index-Processors-Fields, config-schema, transliteration authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2, 2257113-Index-Processors-Fields, config-schema, transliteration, ignore-case-test-fix authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2, 2257113-Index-Processors-Fields, config-schema, transliteration, ignore-case-test-fix, 2281233-fix-stopwords authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2, 2257113-Index-Processors-Fields, config-schema, transliteration, ignore-case-test-fix, 2281233-fix-stopwords, ignorecase-nick, renamefields authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, move-integration-tests-subfolder, issue-2273743, 2268885-fix-validation, synonyms-processor, 2230925-server-tasks, 2235381-fix-config-schemas-2, 2257113-Index-Processors-Fields, config-schema, transliteration, ignore-case-test-fix, 2281233-fix-stopwords, ignorecase-nick, renamefields authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, issue-2273743, 2268885-fix-validation, synonyms-processor, 2235381-fix-config-schemas-2, config-schema, transliteration, ignore-case-test-fix, ignorecase-nick, renamefields, highlight authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, issue-2273743, 2268885-fix-validation, synonyms-processor, 2235381-fix-config-schemas-2, config-schema, transliteration, ignore-case-test-fix, ignorecase-nick, renamefields, highlight, add-aggregation-nick authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, issue-2273743, 2268885-fix-validation, synonyms-processor, 2235381-fix-config-schemas-2, config-schema, transliteration, ignore-case-test-fix, ignorecase-nick, renamefields, highlight, add-aggregation-nick, 2247923-Test_the_RenderedItem_processor authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Commit d4a8a78 on master, views, htmlfilter, issue-2273743, 2268885-fix-validation, synonyms-processor, 2235381-fix-config-schemas-2, config-schema, transliteration, ignore-case-test-fix, ignorecase-nick, renamefields, highlight, add-aggregation-nick, 2247923-Test_the_RenderedItem_processor, 2286813-fields-processor-plugin-base-test authored by Dragan Eror, committed by Berdir:
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    

  • Berdir committed d4a8a78 on add_aggregatedfield_test authored by Dragan Eror
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    
drunken monkey’s picture

Looking at my index's "View" tab, it seems this is solved now?

  • Berdir committed d4a8a78 on 2349435-seperate-processors-by-stage authored by Dragan Eror
    Issue #2252485 by Dragan Eror: Improved UI for index summary page.
    
drunken monkey’s picture

Status: Needs review » Fixed

I'll assume that's as "Yes".

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.