Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
@amateescu was suggested Index summary page improvements.
Proposed resolution
Improve styling. Basically, get rid of all non-necessary classes and styles and use just default table styles from Drupal core with minimal improvements.
Related issues
#2252713: Table headers inside of status reports look strange.
#2254785: Progress bar 0% or over 100% visual BUG
Comment | File | Size | Author |
---|---|---|---|
#33 | #2252485 use static progress bar.patch | 1.01 KB | x3cion |
#19 | index-summary-2252485-19.patch | 490 bytes | Dragan Eror |
#17 | index-summary-2252485-17.patch | 287 bytes | Dragan Eror |
#10 | index-summary-2252485-10.patch | 2.13 KB | Dragan Eror |
#8 | index-summary-2252485-8.patch | 2.04 KB | Dragan Eror |
Comments
Comment #1
Dragan Eror CreditAttribution: Dragan Eror commentedComment #2
Dragan Eror CreditAttribution: Dragan Eror commentedComment #3
Dragan Eror CreditAttribution: Dragan Eror commentedComment #4
Dragan Eror CreditAttribution: Dragan Eror commentedComment #5
Dragan Eror CreditAttribution: Dragan Eror commentedHere are some improvements of index summary page...
Comment #6
Dragan Eror CreditAttribution: Dragan Eror commentedAdded new line at the end of file.
Comment #7
s_leu CreditAttribution: s_leu commentedI would call it "Styles for index status page."
Fullstop at the end of sentence is missing.
Rest looks good to me.
Comment #8
Dragan Eror CreditAttribution: Dragan Eror commentedHere are patch improvements...
Comment #9
s_leu CreditAttribution: s_leu commentedOk fine.
Comment #10
Dragan Eror CreditAttribution: Dragan Eror commentedRemoved animation from progress bar.
Comment #11
BerdirCommitted.
Comment #13
aspilicious CreditAttribution: aspilicious commentedCan we add some left margin or padding on the first column?
The word "status" is glued against the border of the box.
Comment #14
aspilicious CreditAttribution: aspilicious commentedAnd another thing, why didn't we make the background color of the first column match the screenshot in the summary?
Comment #15
Berdir@aspilicious: That's fixed by the referenced core issue.
Comment #16
Dragan Eror CreditAttribution: Dragan Eror commented@aspilicious in the mean time the opinion was changed. The first requirement was changed from make it look like status page to just make it use core styles for table (fixed in description), with minimal improvement.
Just now there is no CSS styles applied on that table.
OK, discussed with @Berdir, I'll improve that table a bit for our purposes.
Comment #17
Dragan Eror CreditAttribution: Dragan Eror commentedImproved table, added padding on the left side for first column. The background will not be changed here in this issue unless is explicitly required.
Comment #18
aspilicious CreditAttribution: aspilicious commentedComment #19
Dragan Eror CreditAttribution: Dragan Eror commentedUpdated issue name to fit also server summary page.
Also table styles for server summary page are applied.
Comment #22
LewisNymanWhy are we removing the animation from the progress bar on this page? The behaviour of the progress bar should be consistent on every page.
Comment #23
Dragan Eror CreditAttribution: Dragan Eror commentedThat was requirement by @Berdir, @amateescu and @drunken_monkey :)
Basically we agreed it looks so strange because you never see when it moves. Or maybe we should introduce "static" progress bar also in core?
And btw, the animation is "moving" in wrong direction, to left, it should go to right like it is natural.
Comment #24
drunken monkeySince there is no progress currently happening, I don't think the normal progress bar is adequate here. I'm no UI expert, but it just looks very strange. Having a quick overview of the current progress is still useful, though, which is why I think the bar should stay, just unanimated (like it is currently in D7).
Comment #30
LewisNymanSure, but changing how the progress bar behaves depending on which module uses it introduces inconsistency for people using these modules. This is a really bad idea. If you have opinions about the current progress bar, that's great, let's talk about that in a core issue. It's possible that we've just identified a situation that we hadn't considered previously or maybe a progress bar is not suitable for the information you're communicating.
Comment #31
Dragan Eror CreditAttribution: Dragan Eror commentedI agree, let's talk... We discovered 2 things here that don't have too much sense:
Suggesting to introduce 'static' progress bar state without animation.
And suggesting to switch animation direction for animated one.
@LewisNyman will you be willing to open new issue in core please?
Comment #32
LewisNymanI have create #2277551: Add a 'static' variant to the progress bar. I'm not going to create an issue to change the animation direction because we've already justified the current direction and it would imply that I agree. Feel free to create it so we can discuss.
Comment #33
x3cion CreditAttribution: x3cion commentedHi,
I've created a patch for #2277551: Add a 'static' variant to the progress bar and if it is accepted - or whatever has to be done for it to get implemented - you'd need the patch attached here.
Comment #49
drunken monkeyLooking at my index's "View" tab, it seems this is solved now?
Comment #51
drunken monkeyI'll assume that's as "Yes".