Loading the admin/config/development/testing page on a PHP version lower than 5.5 gives the following error:

PHP Fatal error: Can't use function return value in write context in /Applications/MAMP/htdocs/openfed/profiles/openfed/modules/contrib/webform_clear/webform_clear.test on line 139

CommentFileSizeAuthor
#2 interdiff.txt2.85 KBstefan.r
#2 webform_clear-2250027-testfix-2.patch3.59 KBstefan.r
#1 webform_clear-2250027-testfix.patch1.22 KBstefan.r
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Active » Needs review
FileSize
webform_clear-2250027-testfix.patch1.22 KB
stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
FileSize
webform_clear-2250027-testfix-2.patch3.59 KB
interdiff.txt2.85 KB

Further improvements to the tests, they pass with Webform 4.x now as well.

adammalone’s picture

adammalone
Primary language English
Location Sydney
CreditAttribution: adammalone commented
Version: 7.x-2.0 » 7.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

This all looks really sane, as well as allowing the testing page to not fatal. Applies cleanly against latest 7.x-2.x

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Assigned: stefan.r » Unassigned