In FireFox, window.matchMedia exists but returns null when used in a hidden iframe. As a result, colorbox.js, which tests for window.matchMedia, causes a JavaScript error when loaded in an iframe (for example, as an AJAX return into a lightbox/thickbox modal window).

CommentFileSizeAuthor
#1 colorbox-javascript_error_mq_is_null_in_firefox_iframe-2242457-1.patch580 bytesjay.dansand
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jay.dansand’s picture

jay.dansand CreditAttribution: jay.dansand commented
FileSize
colorbox-javascript_error_mq_is_null_in_firefox_iframe-2242457-1.patch580 bytes

Here is a patch that tests for the return value and treats an iframe the same as a "small window" (it disables Colorbox).

Paul B’s picture

Paul B CreditAttribution: Paul B commented
Status: Active » Needs review
jay.dansand’s picture

jay.dansand CreditAttribution: jay.dansand as a volunteer commented

This is still relevant - it'd be great if we didn't need to keep reapplying this patch every release (the patch from #1 still applies cleanly).

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Closed (cannot reproduce)