There needs to be isset checks for the path attribute of $this->display->display_options. We are using this block in panels and when used in this way it doesn't have a path attribute like a regular block implementation does. While this is only a notice and will be disabled on most production sites, I feel it is important to correct issues like this because it slows php execution time.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrmikedewolf’s picture

Issue summary: View changes

Patch coming.

mrmikedewolf’s picture

Here is a patch to perform the checks.

joelpittet’s picture

Version: 7.x-3.0-beta4 » 7.x-3.x-dev
Status: Active » Needs work

@mrmikedewolf this looks like a good idea to check this. Two things:

  1. This doesn't apply cleanly against dev version. Do you mind re-rolling it?
  2. It would be a minor performance improvement (super minor actually) but maybe a good idea to put that isset() value in the front?
joshf’s picture

Status: Needs work » Needs review
FileSize
2.7 KB

New patch incorporating @joelpittet's comments.

joshf’s picture

Assigned: mrmikedewolf » Unassigned
joelpittet’s picture

@joshf thanks for the re-roll.

This may not be needed any more. Consider that it's now using get_path() and before it was directly trying to access $this->display->display_options['path']

+++ b/better_exposed_filters_exposed_form_plugin.inc
@@ -915,7 +915,7 @@ Title Desc|Z -> A</pre> Leave the replacement value blank to remove an option al
               $form['items_per_page']['#bef_path'] = $this->view->get_path();
mikeker’s picture

Status: Needs review » Closed (works as designed)
Issue tags: -Exposed Block, -panels

I believe @joelpittet is correct -- I'm unable to raise any warnings when using the exposed filter form in Panels with BEF. Thanks to all for the initial bug report, patches, and rerolls. And my apologies for not getting to this issue sooner.

If anyone is still seeing these warnings, please reopen this issue and include an export of the view that raises them.