Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
There needs to be isset checks for the path attribute of $this->display->display_options. We are using this block in panels and when used in this way it doesn't have a path attribute like a regular block implementation does. While this is only a notice and will be disabled on most production sites, I feel it is important to correct issues like this because it slows php execution time.
Comment | File | Size | Author |
---|---|---|---|
#4 | better_exposed_filters-panels_block_path_check-2241591-4.patch | 2.7 KB | joshf |
Comments
Comment #1
mrmikedewolf CreditAttribution: mrmikedewolf commentedPatch coming.
Comment #2
mrmikedewolf CreditAttribution: mrmikedewolf commentedHere is a patch to perform the checks.
Comment #3
joelpittet@mrmikedewolf this looks like a good idea to check this. Two things:
Comment #4
joshf CreditAttribution: joshf commentedNew patch incorporating @joelpittet's comments.
Comment #5
joshf CreditAttribution: joshf commentedComment #6
joelpittet@joshf thanks for the re-roll.
This may not be needed any more. Consider that it's now using get_path() and before it was directly trying to access
$this->display->display_options['path']
Comment #7
mikeker CreditAttribution: mikeker commentedI believe @joelpittet is correct -- I'm unable to raise any warnings when using the exposed filter form in Panels with BEF. Thanks to all for the initial bug report, patches, and rerolls. And my apologies for not getting to this issue sooner.
If anyone is still seeing these warnings, please reopen this issue and include an export of the view that raises them.