Do not try to cache/aggregate/compress G2 javascript [#224019]

below is the warning. currently no albums or photos loaded on this test server.

warning: file_get_contents(?q=gallery&g2_view=core.CombinedJavascript&g2_key=7f0ca943003f9994cf711d6bb1eafdfb&g2_GALLERYSID=02e1f5067b45f4f6f6e7d08726e52e73) [function.file-get-contents]: failed to open stream: No such file or directory in /Users/sites/drupal6/includes/locale.inc on line 1622.
warning: file_get_contents(Sites/drupal6/gallery2/main.php?g2_view=core.ItemDeleteJs&g2_lang=en_US&g2_GALLERYSID=02e1f5067b45f4f6f6e7d08726e52e73) [function.file-get-contents]: failed to open stream: No such file or directory in /Users/sites/drupal6/includes/locale.inc on line 1622

Comments

Comment #1

profix898 CreditAttribution: profix898 commented 20 February 2008 at 01:36

There are several issues with the new JS features in G2.3, especially with the JS aggregator. We definitely need to investigate this further. An issue about broken YUI widgets with G2.3 can be found at http://drupal.org/node/188035.

Comment #2

profix898 CreditAttribution: profix898 commented 25 February 2008 at 00:00

Title:	error in admin>build>modules after installing 2/18 version	» Do not try to cache/aggregate/compress G2 javascript
Status:	Active	» Fixed

As G2 now includes its own JS aggregator we should not try to process G2 javascript in Drupal again. Patch to prevent Drupal to do so committed to 6--1 branch. The ".file-get-contents" warning is caused by the Drupal js aggregator in attempt to fetch the G2 js and should be gone with the latest patch.

Comment #3

thumb CreditAttribution: thumb commented 25 February 2008 at 04:28

Any chance of a backport of this patch to 5.x-2.x?

Comment #4

profix898 CreditAttribution: profix898 commented 25 February 2008 at 12:26

Status:

Fixed

» Patch (to be ported)

Drupal 5 does not have a js aggregator, but only a premature version of a js cache. D5 never caches something actively. It only appends a url fragment, so that the url changes a little every time the page is reloaded. Nothing more. I'm not sure we really need to backport this. The new G2.3 js aggregrator already includes a 'key' to force browsers to reload js if required. Telling Drupal to not cache the file in D5 only results in a second time-dependent fragment being appended to the url.

Marking "patch (to be ported)" for now and will investigate in more detail ...

Comment #5

profix898 CreditAttribution: profix898 commented 8 June 2008 at 23:25

Status:

Patch (to be ported)

» Fixed

I removed most of the JS/CSS handling code from the module. This means we no longer use drupal_add_js/css but we inject the G2 JS/CSS directly into head (drupal_set_html_head). I dont see any way to bypass the aggregator in Drupal 6.x and to avoid the appended query string (for caching purposes), that basically corrupts the urls of all G2 includes.