From https://api.drupal.org/api/drupal/includes!entity.inc/function/EntityFie...

    $this->ordered_results[] = $partial_entity;

AFAICT this isn't used anywhere else, either in the class or in Drupal core in general.

Files: 
CommentFileSizeAuthor
#1 drupal-2239355-1.patch580 bytescs_shadow
PASSED: [[SimpleTest]]: [MySQL] 41,255 pass(es).
[ View ]

Comments

cs_shadow’s picture

Status:Active» Needs review
StatusFileSize
new580 bytes
PASSED: [[SimpleTest]]: [MySQL] 41,255 pass(es).
[ View ]

Attached is a patch that removes the unnecessary assignment.

saorab’s picture

Status:Needs review» Reviewed & tested by the community

The patch has been applied successfully.
Hunk #1 succeeded at 1331 (offset 14 lines)"

Checked the entity.inc file, the mentioned unnecessary assignment is not present anymore.
The presence or absence of the code doesn't affect anywhere AFAICT.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 1: drupal-2239355-1.patch, failed testing.

amitgoyal’s picture

Status:Needs work» Needs review
StatusFileSize
new580 bytes
FAILED: [[SimpleTest]]: [MySQL] 41,124 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Let's see if it works with cleaner patch.

dcam’s picture

1: drupal-2239355-1.patch queued for re-testing.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

#1 is still RTBC.

I don't know what is "cleaner" about #4 because its changes are identical to #1. Only the line numbers have changed, however, a reroll of #1 wasn't necessary because it still applies.

amitgoyal’s picture

As mentioned in #2, "Hunk #1 succeeded at 1331 (offset 14 lines)", I recreated the patch which allies cleanly without any Hunk/offset.

So just wanted to see if test bot failed due to that or not.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 4: drupal-2239355-4.patch, failed testing.

dcam’s picture

Status:Needs work» Reviewed & tested by the community

joachim queued 4: drupal-2239355-4.patch for re-testing.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 4: drupal-2239355-4.patch, failed testing.

Status:Needs work» Needs review

dcam queued 4: drupal-2239355-4.patch for re-testing.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 4: drupal-2239355-4.patch, failed testing.

Status:Needs work» Needs review

dcam queued 4: drupal-2239355-4.patch for re-testing.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 4: drupal-2239355-4.patch, failed testing.

Status:Needs work» Needs review
David_Rothstein’s picture

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 4: drupal-2239355-4.patch, failed testing.

Status:Needs work» Needs review

dcam queued 4: drupal-2239355-4.patch for re-testing.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 4: drupal-2239355-4.patch, failed testing.

Status:Needs work» Needs review

dcam queued 4: drupal-2239355-4.patch for re-testing.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 4: drupal-2239355-4.patch, failed testing.

Status:Needs work» Needs review

dcam queued 4: drupal-2239355-4.patch for re-testing.

dcam’s picture

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 4: drupal-2239355-4.patch, failed testing.

David_Rothstein’s picture

Status:Needs work» Closed (duplicate)
Related issues:+#1292930: EntityFieldQuery uses incorrect ordered_results instead of orderedResults

Simply removing it isn't going to work... this is actually a duplicate of #1292930: EntityFieldQuery uses incorrect ordered_results instead of orderedResults.