Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Child of #2124749: [meta] Stop using $request->attributes->get(MAGIC_KEY) as a public API, but doesn't seem like a big enough deal to warrant blocking beta on, so setting as a beta target instead.
Comment | File | Size | Author |
---|---|---|---|
clean_urls.patch | 3.09 KB | effulgentsia | |
Comments
Comment #1
effulgentsia CreditAttribution: effulgentsia commentedIf someone has a better idea for where this function should live (e.g., do we need it to be a swappable service?), please suggest it.
Comment #2
dawehnerI wonder whether it is okay to not put it onto the wrapper we had in the other issue (RequestAdapter or how it was called),
but this seems to be nice for now.
I really don't think we need. First, it is not used in many places (so you could swap out the image style if really needed)
and much more important it is tight really hard to the logic a request has, which is not PHP anymore.
Comment #3
webchickSeems sane.
Committed and pushed to 8.x. Thanks.