Clean up StringDatabaseStorage doxygen

Looks good to me :)

The only change code change is -use Drupal\Core\Database\Database;, which I don't see locally either why would be needed. Sending for a retest.

locale_docs.patch queued for re-testing.

I don't think this is actually quite ready:

a) The formatting here is a bit off:

    * @return string
-   *   Either 's', 't' or 'l' depending on whether the field belongs to source,
-   *   target or location table table.
+   *   - 's' for "source", "context", "version" (locales_source table fields).
+   *   - 'l' for "type", "name" (locales_location table fields)
+   *   - 't' for "language", "translation", "customized" (locales_target
+   *   table fields)
    */
   protected function dbFieldTable($field) {

- Lists should be preceded by a line like "One of the following values:"
- The last line should be indented 2 more spaces.

b)

-   * @return \Drupal\locale\LocaleString
+   * @return \Drupal\locale\StringInterface
    *   The called object.
    */
   public function setId($id);

This should just say "@return $this" with no description. Several methods below have the same thing.

Updating patch as said in comment 6. Please review.

Almost :)

+++ b/core/modules/locale/lib/Drupal/locale/StringDatabaseStorage.php
@@ -248,11 +245,15 @@ public function createTranslation($values = array()) {
+   *   Use one of the following values.

Should use : not .

Ok.

Used ':' instead of '.' and updating patch. updating patch wth this change

Also updated from "Use one of the..." to "One of the" on the same line, since this is a return value, not an argument. Same was suggested by @jhodgdon above. This is such a minor change and all other changes look good that this is RTBC :)

Thanks - also looks good to me. Committed to 8.x.