In common.inc the use statements are declared above the doc file which is incorrect. first in file should always the doc file be written.

Parent issue need to be solved first.

CommentFileSizeAuthor
#2 drupal-use_statements_before_doc_file-2237767-2.patch961 bytescs_shadow
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

filijonka’s picture

filijonka CreditAttribution: filijonka commented
Issue summary: View changes
cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
FileSize
drupal-use_statements_before_doc_file-2237767-2.patch961 bytes

Attaching a patch where doc file is moved above use statements.

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
Status: Active » Needs review
jmarkel’s picture

jmarkel CreditAttribution: jmarkel commented
Status: Needs review » Reviewed & tested by the community

Reviewed code by eye - looks good. Ran with the patch as well, everything appears to continue to work as expected (which is no surprise, since this is a doc-only change).

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice find! Committed and pushed to 8.x. Thanks!

  • Commit 07734e1 on 8.x by webchick: 
    Issue #2237767 by cs_shadow | filijonka: Use statements before doc file.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.